Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: package removal request for github.com/DataDog/datadog-agent #48865

Closed
djmitche opened this issue Oct 8, 2021 · 4 comments
Closed

x/pkgsite: package removal request for github.com/DataDog/datadog-agent #48865

djmitche opened this issue Oct 8, 2021 · 4 comments
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Milestone
pkgsite/package-r...

Comments

@djmitche
Copy link

djmitche commented Oct 8, 2021

What is the path of the package that you would like to have removed?

github.com/DataDog/datadog-agent (but not sub-packages such as github.com/DataDog/datadog-agent/pkg/util/log)

Are you the owner of this package?

Yes, I am on the agent-core team at DataDog, as the GitHub team membership confirms.

What is the reason that you could not retract this package instead?

We are seeing an old tag at https://pkg.go.dev/github.com/DataDog/datadog-agent, but would like to see the latest and greatest in that package.

The package is public, but not intended for linkage by other go projects: we don't guarantee any sort of API compatibility. So, we would prefer to have it appear un-versioned, with just the latest commit to main appearing. My understanding is that the only way to retract a version is to publish a new version.
@gopherbot gopherbot added this to the Unreleased milestone Oct 8, 2021
@seankhliao
Copy link
Member

You can publish a higher version and retract it at the same time, eg v0.8.1 which retracts both v0.8.0 and v0.8.1

@djmitche djmitche changed the title x/pkgsite: package removal request for [type path here] x/pkgsite: package removal request for github.com/DataDog/datadog-agent Oct 8, 2021
@jamalc
Copy link

jamalc commented Oct 8, 2021

Package removal can only be applied to all versions (tagged and untagged) of the package and includes sub-packages. To have it appear un-versioned follow @seankhliao's suggestion.

@jamalc jamalc closed this as completed Oct 8, 2021
@djmitche
Copy link
Author

djmitche commented Oct 8, 2021

As a followup for the next person to see this -- note that while the above works for go list and other commands, it does not cause the pkg.go.dev site to begin showing the latest version on the main branch. Instead, it shows the latest (retracted) version with a "RETRACTED" banner, and clicking "latest" brings you to a list of published versions. So basically, once you tag a Git repo, there's no going back to un-tagged docs.

@djmitche
Copy link
Author

It appears that there was some daily (or weekly?) job that ran that fixed things, as https://pkg.go.dev/github.com/djmitche/proj is again showing the latest from the default branch.

@hyangah hyangah added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label May 20, 2022
@golang golang locked and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Milestone
pkgsite/package-removal
Development

No branches or pull requests
6 participants
@djmitche @hyangah @julieqiu @gopherbot @seankhliao @jamalc