Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cgo: fails to bootstrap on illumos-amd64 builder with "undefined: ast.IndexListExpr" #48863

Closed
bcmills opened this issue Oct 8, 2021 · 11 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-illumos release-blocker
Milestone

Comments

@bcmills bcmills changed the title cmd/cgo: fails to bootstrap on illumos-amd64 builder due to "undefined: ast.IndexListExpr". cmd/cgo: fails to bootstrap on illumos-amd64 builder with "undefined: ast.IndexListExpr" Oct 8, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Oct 8, 2021

@jclulow, it looks like /opt/go/bootstrap/bin/go on this builder is an earlier build of go1.18. That's not going to work: the meaning of the current go1.X build tag changes as the release is developed, so an earlier development build of go1.18 will try (and fail) to build files tagged //go:build go1.18 that use APIs added later during development.

The bootstrap Go compiler really needs to be a stable release of some sort. (Maybe install Go 1.17.2 instead?)

$ mote run /opt/go/bootstrap/bin/go version
go version devel go1.18-a2a9a7b513 Tue Aug 17 21:34:32 2021 +0000 illumos/amd64

@bcmills bcmills added Builders x/build issues (builders, bots, dashboards) OS-illumos NeedsFix The path to resolution is known, but the work has not been done. labels Oct 8, 2021
@bcmills bcmills added this to the Go1.18 milestone Oct 8, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Oct 8, 2021

@golang/release: the illumos-amd64 builder is currently broken, and needs to have a different bootstrap toolchain installed or configured.

@dmitshur
Copy link
Contributor

dmitshur commented Oct 8, 2021

@jclulow is the owner of the illumos-amd64 builder listed at https://farmer.golang.org/builders, and I understand the only one able to resolve this issue. Please let us know if someone else can help.

I agree with the suggestion of using Go 1.17.2 as the bootstrap, as that is both stable and satisfies proposal #44505. Go 1.16.9 would also work well as a bootstrap version.

@gopherbot
Copy link

Change https://golang.org/cl/354695 mentions this issue: cmd/cgo: use "!compiler_bootstrap" tag instead of "go1.18"

@jclulow
Copy link
Contributor

jclulow commented Oct 8, 2021

Sorry about that, I'll get it sorted today!

@dmitshur
Copy link
Contributor

dmitshur commented Oct 8, 2021

Thanks very much @jclulow!

The issue affecting cmd/cgo and causing a visible failure was fixed via CL 354695, which is why this issue is closed now, but updating the illumos-amd64 builder to use a stable Go 1.16 or 1.17 release will still be helpful and appreciated, as it can avoid similar problems in the future and improve our confidence in the test results. Thanks again!

@jclulow
Copy link
Contributor

jclulow commented Oct 8, 2021

Thanks for continuing to build/test on illumos! We're a small community but we very much appreciate it.

OK, I believe I have sorted that out:

root@gobuild1:~# /opt/go/bootstrap/bin/go version
go version go1.17.2 illumos/amd64

Please let me know if there are any other issues with the builder and I'll get right on it.

@bcmills
Copy link
Contributor Author

bcmills commented Oct 11, 2021

@jclulow, unfortunately it looks like there is something wrong with the go1.17.2 install: the builds appear to be failing with status 1 during bootstrapping. 😞

(https://build.golang.org/log/a685b33285906460051c63d763beb5c4a843beb3)

@jclulow
Copy link
Contributor

jclulow commented Oct 11, 2021

Oh no! I will take a look.

@jclulow
Copy link
Contributor

jclulow commented Oct 12, 2021

OK, so, the first 1.17.2 bits were built on my Linux workstation using the bootstrap script, with a clone of the tree at the 1.17.2 tag. I'm not sure why those don't work.

I've replaced them with a native (on illumos) build of 1.17.2 from the official source archive at golang.org. When I built it, it told me ALL TESTS PASSED so hopefully it is alright!

I'll check in on the build jobs tomorrow. Sorry about the mess!

@bcmills
Copy link
Contributor Author

bcmills commented Oct 12, 2021

Looks like it's passing now. Thanks for persevering!

@golang golang locked and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-illumos release-blocker
Projects
None yet
Development

No branches or pull requests

4 participants