Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: missing testable examples for IP functions #48848

Closed
ameowlia opened this issue Oct 7, 2021 · 2 comments
Closed

net: missing testable examples for IP functions #48848

ameowlia opened this issue Oct 7, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@ameowlia
Copy link
Contributor

ameowlia commented Oct 7, 2021

What did you do?

Looked at the docs for the net package.

What did you expect to see?

I expected to see testable examples for more of the IP functions.

What did you see instead?

I saw only a few testable examples for the IP functions.

@gopherbot
Copy link

Change https://golang.org/cl/346289 mentions this issue: net: add examples for remaining IP functions

@mknyszek
Copy link
Contributor

mknyszek commented Oct 7, 2021

In these cases, feel free to just send a CL. No need to file an issue. Closing...

CC @neild

@mknyszek mknyszek closed this as completed Oct 7, 2021
@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 7, 2021
@mknyszek mknyszek added this to the Backlog milestone Oct 7, 2021
gopherbot pushed a commit that referenced this issue Oct 13, 2021
Fixes #48848

Change-Id: If85fc16ed10a26eca840ed128ab47c5f00776ddd
Reviewed-on: https://go-review.googlesource.com/c/go/+/346289
Reviewed-by: Amelia Downs <adowns@vmware.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
@golang golang locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants