Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/pprof: update vendored pprof #48839

Closed
mhansen opened this issue Oct 7, 2021 · 5 comments
Closed

cmd/pprof: update vendored pprof #48839

mhansen opened this issue Oct 7, 2021 · 5 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18

Comments

@mhansen
Copy link
Contributor

mhansen commented Oct 7, 2021 •
edited

Hi there,

@aalexand and I recently landed a change to github.com/google/pprof to add -tagroot and -tagleaf support for breaking down flamegraph profiles by pprof labels. I imagine this will be particularly useful for Go programs where labels are exposed in the runtime to users.

I'd like to request a pull of the latest github.com/google/pprof into https://github.com/golang/go/tree/master/src/cmd/vendor/github.com/google/pprof, to get this feature into the next Go release, so I can write up my blog post and tell people after the next Go version ships?

I see this was last updated 29 days ago with 9581d89, so perhaps I'm too late. It's OK if I have to wait till the next Go release (if there's a freeze or something), I just thought I'd open this issue in case you're excited about this getting this new profiling feature into the hands of users.
@mhansen
Copy link
Contributor Author

mhansen commented Oct 7, 2021

@dmitshur, maybe you're the person to ask about this, given you just made the last update to the vendored pprof?

@ALTree
Copy link
Member

ALTree commented Oct 7, 2021

The 1.18 freeze starts November 1st, this pprof change could definitely still go in.

@ALTree ALTree changed the title Requesting update to vendored pprof cmd/pprof: requesting update to vendored pprof Oct 7, 2021
@ALTree ALTree added this to the Go1.18 milestone Oct 7, 2021
@bcmills
Copy link
Contributor

bcmills commented Oct 7, 2021

Yep, just send a CL to update it! (See https://cs.opensource.google/go/go/+/master:src/README.vendor for instructions.)

@bcmills bcmills added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Oct 7, 2021
@bcmills bcmills changed the title cmd/pprof: requesting update to vendored pprof cmd/pprof: update vendored pprof Oct 7, 2021
@mhansen
Copy link
Contributor Author

mhansen commented Oct 7, 2021

Thank you for the pointers and confirmation it's not too late! I'll have a go at this

mhansen added a commit to mhansen/go that referenced this issue Oct 8, 2021
@mhansen
cmd/pprof: update vendored github.com/google/pprof
b26260f 
Pull in the latest published version of github.com/google/pprof

This adds the `tagroot` and `tagleaf` options from
google/pprof@7fe48b4

Done with:

  go get -d github.com/google/pprof@latest
  go mod tidy
  go mod vendor

Fixes golang#48839
@mhansen mhansen mentioned this issue Oct 8, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/354692 mentions this issue: cmd/pprof: update vendored github.com/google/pprof

@golang golang locked and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18
Development

Successfully merging a pull request may close this issue.

cmd/pprof: update vendored github.com/google/pprof mhansen/go
4 participants
@mhansen @ALTree @bcmills @gopherbot