-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/pprof: update vendored pprof #48839
Comments
@dmitshur, maybe you're the person to ask about this, given you just made the last update to the vendored pprof? |
The 1.18 freeze starts November 1st, this pprof change could definitely still go in. |
Yep, just send a CL to update it! (See https://cs.opensource.google/go/go/+/master:src/README.vendor for instructions.) |
Thank you for the pointers and confirmation it's not too late! I'll have a go at this |
Pull in the latest published version of github.com/google/pprof This adds the `tagroot` and `tagleaf` options from google/pprof@7fe48b4 Done with: go get -d github.com/google/pprof@latest go mod tidy go mod vendor Fixes golang#48839
Change https://golang.org/cl/354692 mentions this issue: |
Hi there,
@aalexand and I recently landed a change to github.com/google/pprof to add
-tagroot
and-tagleaf
support for breaking down flamegraph profiles by pprof labels. I imagine this will be particularly useful for Go programs where labels are exposed in the runtime to users.I'd like to request a pull of the latest github.com/google/pprof into https://github.com/golang/go/tree/master/src/cmd/vendor/github.com/google/pprof, to get this feature into the next Go release, so I can write up my blog post and tell people after the next Go version ships?
I see this was last updated 29 days ago with 9581d89, so perhaps I'm too late. It's OK if I have to wait till the next Go release (if there's a freeze or something), I just thought I'd open this issue in case you're excited about this getting this new profiling feature into the hands of users.
The text was updated successfully, but these errors were encountered: