Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: regressed and non-informative error messages when return call site doesn't match return signature #48834

Closed
odeke-em opened this issue Oct 7, 2021 · 3 comments
Closed

cmd/compile: regressed and non-informative error messages when return call site doesn't match return signature #48834

odeke-em opened this issue Oct 7, 2021 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.18

Comments

@odeke-em
Copy link
Member

odeke-em commented Oct 7, 2021

What version of Go are you using (go version)?

GoTip at 6f74ed0 aka Go1.18

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)? Not Applicable

What did you do?

Ran this program https://play.golang.org/p/uUOlQ-99Wx_y or inlined below

package main

func foo() (int, error) {
	return nil
}

func main() {}

What did you expect to see?

./main.go:4:2: not enough arguments to return
	have (nil)
	want (int, error)

What did you see instead?

./main.go:4:2: wrong number of return values (want 2, got 1)

This is a regression from Go1.8 and it is unique in the upcoming Go1.18; I understand there have been compiler rewrites but just a count of arguments takes us back to square 0 where we were, yet we had worked on improving the user experience of these messages. This was one of my first contributions to the compiler driven after getting feedback from users at Gophercon 2016 fixing at least 2 issues #4215 and #6750.

Kindly cc-ing @mdempsky @griesemer
@odeke-em odeke-em added this to the Go1.18 milestone Oct 7, 2021
@odeke-em odeke-em self-assigned this Oct 7, 2021
@gopherbot
Copy link

Change https://golang.org/cl/354490 mentions this issue: cmd/compile/internal/types2: report types in mismatched call arguments

@gopherbot
Copy link

Change https://golang.org/cl/364874 mentions this issue: cmd/compile/internal/types2: report types for mismatched call and return statements

@gopherbot
Copy link

Change https://golang.org/cl/367196 mentions this issue: go/types: report types for mismatched call and return statements

gopherbot pushed a commit that referenced this issue Nov 29, 2021
@griesemer
go/types: report types for mismatched call and return statements
2f6d382 
This is a port of CL 364874 from types2 to go/types with various
adjustments:

- the error position for "not enough arguments" in calls is the
  closing ) rather than the position of the last provided argument

- the ERROR comments in tests are positioned accordingly

- the reg. expression for matching error strings accepts newlines
  for the . pattern (added s flag)

For #48834.
For #48835.

Change-Id: I64362ecf605bcf9d89b8dc121432e0131bd5da1b
Reviewed-on: https://go-review.googlesource.com/c/go/+/367196
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@odeke-em @gopherbot