Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: TestTransportReqBodyAfterResponse_403 failures with "want (0,10485760) exclusive" on js-wasm since Oct 4 #48792

Closed
bcmills opened this issue Oct 5, 2021 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-JS release-blocker
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 5, 2021

--- FAIL: TestTransportReqBodyAfterResponse_403 (0.10s)
    transport_test.go:837: client: For 403 response, Transport wrote 10485760 bytes; want (0,10485760) exclusive
FAIL
FAIL	golang.org/x/net/http2	69.113s

The first occurrence of this failure mode in the logs was at CL 353390 (CC @neild), so this looks like a recent regression.

greplogs --dashboard -md -l -e '(?ms)FAIL: TestTransportReqBodyAfterResponse_403.*want .* exclusive'

2021-10-05T07:32:41-d4b1ae0-d55009c/js-wasm
2021-10-04T19:50:52-b30845b-7d822af/js-wasm
2021-10-04T18:58:42-cedda3a-7d822af/js-wasm
2021-10-04T16:44:53-cedda3a-9432320/js-wasm

@bcmills bcmills added OS-JS NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 5, 2021
@bcmills bcmills added this to the Go1.18 milestone Oct 5, 2021
@gopherbot
Copy link

Change https://golang.org/cl/354130 mentions this issue: http2: avoid race in TestTransportReqBodyAfterResponse_403.

dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
This test sends a request with a 10MiB body, reads a 403 response
while the body is still being written, and closes the response body.
It then verifies that the full request body was not written, since
reading a response code >=300 interrupts body writes.

This can be racy: We process the status code and interrupt the body
write in RoundTrip, but it is possible for the body write to complete
before RoundTrip looks at the response.

Adjust the test to have more control over the request body:
Only provide half the Request.Body until after the response headers
have been received.

Fixes golang/go#48792.

Change-Id: Id4802b04a50f34f6af28f4eb93e37ef70a33a068
Reviewed-on: https://go-review.googlesource.com/c/net/+/354130
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-JS release-blocker
Projects
None yet
Development

No branches or pull requests

2 participants