Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Incorrect "latest" version leads to missing "Deprecated" message. #48783

Closed
lgarron opened this issue Oct 5, 2021 · 4 comments
Closed
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite

Comments

@lgarron
Copy link

lgarron commented Oct 5, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/github/fakeca

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.71 Safari/537.36

Screenshot

Screen Shot 2021-10-04 at 17 07 37

What did you do?

I published a v0.2.0 tag for three packages, each with a similar // Deprecated: comment in go.mod:

What did you expect to see?

All three show a ⚠ Deprecated message like this:

Screen Shot 2021-10-04 at 17 09 01

What did you see instead?

https://pkg.go.dev/github.com/github/fakeca doesn't show the message, but the other packages do.


https://pkg.go.dev/github.com/github/fakeca?tab=versions seems to know about v0.2.0 but it doesn't seem to be getting picked up as the "latest". https://pkg.go.dev/github.com/github/fakeca@v0.2.0 shows this, and clicking "Go to latest" takes you to v0.1.0:

Screen Shot 2021-10-04 at 17 14 01

@gopherbot gopherbot added this to the Unreleased milestone Oct 5, 2021
@lgarron lgarron changed the title x/pkgsite: x/pkgsite: Incorrect "latest" version leads to missing "Deprecated" message. Oct 5, 2021
@FiloSottile
Copy link
Contributor

The proxy has the right latest, so pkgsite seems to be behind.

go mod download -json github.com/github/fakeca@latest
{
	"Path": "github.com/github/fakeca",
	"Version": "v0.2.0",
	"Info": "/Users/filippo/pkg/mod/cache/download/github.com/github/fakeca/@v/v0.2.0.info",
	"GoMod": "/Users/filippo/pkg/mod/cache/download/github.com/github/fakeca/@v/v0.2.0.mod",
	"Zip": "/Users/filippo/pkg/mod/cache/download/github.com/github/fakeca/@v/v0.2.0.zip",
	"Dir": "/Users/filippo/pkg/mod/github.com/github/fakeca@v0.2.0",
	"Sum": "h1:xtBwXN7dmDPK8U5z0KHW1jupDVTDSINxrKRAc5//XFY=",
	"GoModSum": "h1:XhVUBgZ9+o0O6XzVXOl4H5qNxkV/MImtB3FuI/Zcti0="
}

@jamalc jamalc added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 5, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/unplanned Oct 5, 2021
@lgarron
Copy link
Author

lgarron commented Oct 17, 2021

This seems to have resolved itself by now. 🤔

(But as documented with screenshots, it definitely was an issue for a while!)

@nishanths
Copy link

nishanths commented Nov 12, 2021

I'm running into a similar issue with the module github.com/nishanths/exhaustive. The latest tag at the time of writing is v0.7.9, which pkg.go.dev knows about in its versions page: https://pkg.go.dev/github.com/nishanths/exhaustive?tab=versions. However the v0.7.9 main page doesn't seem to think its version the latest. Instead the v0.7.8 main page seems to think its version is the latest.

(And just for completeness, nothing was deprecated in this module between the two versions.)

The command

go mod download -json github.com/nishanths/exhaustive@latest

finds v0.7.9 though.

Screenshots

versions page
Screen Shot 2021-11-12 at 6 16 47 AM

v0.7.9 main page
Screen Shot 2021-11-12 at 6 16 54 AM

v0.7.8 main page
Screen Shot 2021-11-12 at 6 17 01 AM

@jba
Copy link
Contributor

jba commented Nov 29, 2021

I'm not sure exactly what happened there, but I do notice that v0.7.8, ...9, ...10 and ...1 were published within two hours of each other on November 11. It's possible that some out-of-order processing caused a temporary glitch, but it seems fine now: the latest page is v0.7.11, as it should be.

@jba jba closed this as completed Nov 29, 2021
@rsc rsc unassigned jba Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Development

No branches or pull requests

6 participants