Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/workspace: TestMultiModule_OneBrokenModule is still flaky #48775

Closed
bcmills opened this issue Oct 4, 2021 · 5 comments
Closed

x/tools/gopls/internal/regtest/workspace: TestMultiModule_OneBrokenModule is still flaky #48775

bcmills opened this issue Oct 4, 2021 · 5 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
gopls/v0.8.4

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 4, 2021

See previously #44227 (CC @stamblerre).

greplogs --dashboard -md -l -e 'FAIL: TestMultiModule_OneBrokenModule' --since=2021-03-01

2021-10-02T13:52:59-0ebff1a-07a7c6f/darwin-amd64-11_0
2021-09-15T16:32:27-4ba3eff-72bb818/darwin-arm64-11_0-toothrot
2021-08-09T17:59:45-4869184-acbe242/dragonfly-amd64
2021-08-04T21:03:22-f367f01-6e73886/dragonfly-amd64
2021-08-04T15:26:45-309db04-6e73886/dragonfly-amd64
2021-08-04T13:50:16-309db04-7921829/dragonfly-amd64
2021-08-03T20:45:05-2f64839-8a7ee4c/dragonfly-amd64
2021-08-03T16:06:16-594b3a2-8a7ee4c/dragonfly-amd64
2021-08-02T19:06:04-a668498-8a7ee4c/dragonfly-amd64
2021-07-31T23:59:40-3810fa8-b8ca6e5/dragonfly-amd64
2021-07-27T22:01:54-07bc1bf-7cd10c1/dragonfly-amd64
2021-07-26T23:46:13-07bc1bf-840e583/dragonfly-amd64
2021-07-26T20:36:31-07bc1bf-ecaa681/dragonfly-amd64
2021-07-23T18:10:55-46d1522-0914646/dragonfly-amd64
2021-07-22T17:13:07-251092d-c6d89db/dragonfly-amd64
2021-07-22T17:01:15-412ee17-fdb45ac/dragonfly-amd64
2021-07-21T23:55:41-412ee17-3e48c03/dragonfly-amd64
2021-07-21T20:52:30-7f68387-3e48c03/dragonfly-amd64
2021-07-19T17:27:58-6e9046b-6298cfe/dragonfly-amd64
2021-07-18T21:03:43-6e9046b-a66190e/dragonfly-amd64
2021-07-18T21:00:03-6e9046b-650fc21/dragonfly-amd64
2021-07-15T17:35:20-6e9046b-c1cc9f9/dragonfly-amd64
2021-07-15T13:35:41-6e9046b-21a04e3/dragonfly-amd64
2021-07-13T20:49:08-5061c41-a985897/dragonfly-amd64
2021-07-13T12:52:46-3844600-bc51e93/dragonfly-amd64
2021-07-13T12:52:46-3844600-a985897/dragonfly-amd64
2021-07-12T22:00:43-de44776-bc51e93/darwin-amd64-nocgo
2021-07-10T00:32:22-5b540d3-ab4085c/dragonfly-amd64
2021-07-08T21:00:45-cae92d5-296ddf2/dragonfly-amd64
2021-07-08T19:56:07-71eae3a-296ddf2/dragonfly-amd64
2021-07-07T22:29:01-fd00574-5c59e11/dragonfly-amd64
2021-07-07T20:06:16-fd00574-c96833e/dragonfly-amd64
2021-07-02T16:25:10-7edcfe5-6125d0c/plan9-386-0intro
2021-07-02T16:14:50-7edcfe5-03761ed/plan9-386-0intro
2021-07-01T19:09:57-20dafe5-03761ed/dragonfly-amd64
2021-07-01T19:09:57-20dafe5-03761ed/plan9-386-0intro
2021-07-01T18:35:33-20dafe5-877688c/dragonfly-amd64
2021-07-01T08:39:23-20dafe5-cb4cd9e/dragonfly-amd64
2021-06-30T22:02:09-f0847e0-4711bf3/dragonfly-amd64
2021-06-30T01:29:49-72e4d1b-c45e800/dragonfly-amd64
2021-06-29T19:12:30-72e4d1b-3463852/dragonfly-amd64
2021-06-28T23:31:13-12f8456-4bb0847/dragonfly-amd64
2021-06-27T05:06:30-12f8456-c95464f/plan9-386-0intro
2021-06-25T23:53:21-12f8456-ed01cea/plan9-386-0intro
2021-06-25T15:05:05-48cad5e-37f9a8f/dragonfly-amd64
2021-06-24T20:04:22-da404b5-c309c89/dragonfly-amd64
2021-06-24T18:12:53-da404b5-600a2a4/dragonfly-amd64
2021-06-24T00:39:41-d824a74-73496e0/plan9-386-0intro
2021-06-23T15:16:55-d824a74-0ebd5a8/plan9-386-0intro
2021-06-18T22:05:09-d25f906-9401172/dragonfly-amd64
2021-06-17T14:53:37-463a76b-4dede02/plan9-386-0intro
2021-06-17T04:32:50-463a76b-97cee43/plan9-386-0intro
2021-06-17T02:42:36-463a76b-881b6ea/dragonfly-amd64
2021-06-14T21:46:05-4b484fb-0fd20ed/dragonfly-amd64
2021-06-11T17:18:39-4b484fb-e2dc6dd/plan9-386-0intro
2021-06-11T15:30:39-490eac8-2f11284/plan9-386-0intro
2021-06-08T22:35:56-4e58f8f-bcecae2/plan9-386-0intro
2021-06-08T20:45:46-4e58f8f-6551763/plan9-386-0intro
2021-06-05T19:52:26-1225b6f-e1fa260/dragonfly-amd64
2021-06-04T17:45:44-7295a4e-831f937/plan9-386-0intro
2021-06-04T17:45:44-7295a4e-831f937/plan9-amd64-0intro
2021-05-30T17:47:50-6123e5f-3b770f2/plan9-386-0intro
2021-05-26T23:33:38-a3eb095-3075ffc/plan9-386-0intro
2021-05-26T22:54:09-a3eb095-a62c087/plan9-386-0intro
2021-05-24T19:06:05-88a9bcc-873401d/linux-arm-scaleway
2021-05-20T20:37:02-2275bb5-baa934d/plan9-386-0intro
2021-05-20T18:25:17-2275bb5-7c692cc/plan9-386-0intro
2021-05-20T17:40:58-3063790-7c692cc/plan9-386-0intro
2021-05-19T01:09:20-17b3466-15a374d/linux-arm-scaleway
2021-05-15T02:39:08-09ab05b-ce92a20/plan9-386-0intro
2021-05-13T21:16:06-09ab05b-b4833f7/linux-arm-scaleway
2021-05-13T15:33:24-cd1be5d-cde2d85/linux-arm-scaleway
2021-05-11T03:28:22-18795da-326a792/plan9-386-0intro
2021-05-10T19:19:34-ecb7392-dc50683/plan9-386-0intro
2021-05-06T20:30:00-c0140e8-4dbad79/plan9-386-0intro
2021-05-04T21:16:16-f03daea-cd28ca3/plan9-386-0intro
2021-05-04T20:18:55-f03daea-10a082a/linux-arm-scaleway
2021-05-04T19:12:24-f03daea-8c3d217/plan9-386-0intro
2021-05-03T01:35:44-7a6108e-2c9f5a1/plan9-386-0intro
2021-05-02T20:59:26-7a6108e-bb09f8a/plan9-386-0intro
2021-05-02T18:22:19-7a6108e-0d32d9e/plan9-386-0intro
2021-05-01T19:17:47-7a6108e-053fe2f/plan9-386-0intro
2021-04-29T19:34:21-aec1372-72ccabc/linux-arm-scaleway
2021-04-29T11:37:05-800adbe-c4c68fb/plan9-386-0intro
2021-04-29T04:59:52-800adbe-6afa0ae/plan9-386-0intro
2021-04-27T22:46:28-7c72a84-983dea9/plan9-386-0intro
2021-04-27T20:55:22-7c72a84-b9dfaf7/plan9-386-0intro
2021-04-27T19:53:45-d0768c9-b9dfaf7/plan9-386-0intro
2021-04-27T11:55:52-735ed62-6edd573/linux-arm-scaleway
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. labels Oct 4, 2021
@bcmills bcmills added this to the Backlog milestone Oct 4, 2021
@bcmills bcmills added the gopls Issues related to the Go language server, gopls. label Oct 4, 2021
@findleyr findleyr modified the milestones: Backlog, gopls/on-deck Oct 8, 2021
@stamblerre stamblerre self-assigned this Oct 13, 2021
@stamblerre stamblerre removed their assignment Oct 19, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Nov 2, 2021

https://storage.googleapis.com/go-build-log/1011e26b/windows-386-2008_c9391dea.log (a TryBot)

@findleyr findleyr modified the milestones: gopls/v0.7.4, gopls/v0.7.5 Dec 14, 2021
@findleyr findleyr modified the milestones: gopls/v0.7.5, gopls/v0.8.0 Jan 4, 2022
@findleyr findleyr modified the milestones: gopls/v0.8.0, gopls/v0.8.1 Feb 21, 2022
@findleyr findleyr modified the milestones: gopls/v0.8.1, gopls/v0.8.2 Mar 7, 2022
@findleyr findleyr modified the milestones: gopls/v0.8.2, gopls/on-deck Mar 24, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Mar 30, 2022

greplogs --dashboard -md -l -e 'FAIL: TestMultiModule_OneBrokenModule' --since=2021-10-05 --omit=-n2d

2022-03-23T18:02:45-9814b1b-88be85f/linux-amd64-sid
2022-03-10T16:56:17-1670aad-91daaab/darwin-amd64-10_15
2022-01-11T13:55:59-eb07148-90a8482/linux-amd64-longtest
2021-12-28T19:29:29-ee1ca4f-1242f43/openbsd-386-70
2021-12-09T14:38:39-e06c107-61ba0bc/netbsd-amd64-9_0
2021-11-24T21:11:45-7cf1f38-b77f5f9/linux-amd64-wsl
2021-11-17T19:51:32-43b469a-9a33945/openbsd-386-70
2021-10-26T18:33:39-244f92e-11b64b4/darwin-amd64-10_14
2021-10-11T17:02:03-18fa840-577bb7d/linux-386-longtest

@findleyr
Copy link
Contributor

This may also be related to https://go.dev/cl/399625 and #52284, as executing commands appear not to trigger multiple change notifications. Let's see if it goes away with CL 399625.

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Apr 12, 2022
@findleyr findleyr added Testing An issue that has been verified to require only test changes, not just a test failure. and removed gopls/testing labels May 10, 2022
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@bcmills
Copy link
Contributor Author

bcmills commented May 12, 2022

greplogs -l -e 'FAIL: TestMultiModule_OneBrokenModule' --since=2022-03-24

(0 matching logs)

Looks like that did it! 👍

@findleyr findleyr modified the milestones: gopls/later, gopls/v0.8.4 Jul 1, 2022
@golang golang locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
gopls/v0.8.4
Development

No branches or pull requests
4 participants
@bcmills @stamblerre @gopherbot @findleyr