x/tools/gopls: compute analysis facts for non-workspace packages #48738
Labels
FrozenDueToAge
gopls/analysis
Issues related to running analysis in gopls
gopls/performance
Issues related to gopls performance (CPU, memory, etc).
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
What version of Go, VS Code & VS Code Go extension are you using?
Version Information
go version
to get version of Go from the VS Code integrated terminal.gopls -v version
to get version of Gopls from the VS Code integrated terminal.code -v
orcode-insiders -v
to get version of VS Code or VS Code Insiders.Go: Locate Configured Go Tools
command.Share the Go related settings you have added/edited
Run
Preferences: Open Settings (JSON)
command to open your settings.json file.Share all the settings with the
go.
or["go"]
orgopls
prefixes.Describe the bug
When "Go:vet On Save is enabled in settings; and a go file is edited and saved (containing an error that
go vet ./...
does pick up), then no error squiggles appear in the editor to show that there is a vet error.Required behavior
When "Go:vet On Save is enabled in settings; and a go file is edited and saved (containing an error that
go vet ./...
does pick up), then error squiggles MUST appear in the editor to show that there is a vet error.Steps to reproduce the behavior:
testvet.go
with the following codego vet ./...
picks up as having an error.Screenshots or recordings
To be clear, the screenshot below is the behaviour that we WANT to happen and be triggered on save, this is currently not happening and only happens when you manually run the command
Go;vet workspace
In addition to this functionality not working, the user interface helptext in VSCode settings does not make sense. The setting helptext has this text, which refers to functionality that I believe is not longer valid.
I have tried all variations of this setting value; both
package
andworkspace
. Neither works.The text was updated successfully, but these errors were encountered: