-
Notifications
You must be signed in to change notification settings - Fork 18k
internal/fuzz: improperly handling crash that occurs while minimizing interesting input #48731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Change https://golang.org/cl/353355 mentions this issue: |
Change https://golang.org/cl/355691 mentions this issue: |
I'm going to re-open this and have it track non-recoverable crashes that occur during minimization of interesting inputs. Like @jayconrod says in #48163
|
The beta is getting close and this is currently marked as blocking the beta. Any news here? |
Yes I've been working on this for the past few days. I expect to send a patch next week, and will get it reviewed quickly. If it ends up getting too close to the beta and we can't get the full fix in, I have a workaround that we can do which is a fairly small change. Will re-assess next week. The beta won't come out until December 15 at the earliest, due to the 2 week delay, correct? Just want to make sure I understand the timeline correctly. (For the fuzzing team - the smaller change would be to just fail minimization and use the initial input instead if a non-recoverable error occurs during minimization. This is especially fine if the reason we're minimizing is b/c we found a recoverable error. It's less great if it was during minimization of an interesting input, since that would bury a crash. But it would probably be reasonable for 1.18) |
We're trying to get the beta done in early December -- if it's ready on Dec 1, we'll ship it then, if it's not ready until the 15th that's okay too. Earlier is better if convenient. |
Change https://golang.org/cl/367848 mentions this issue: |
Found a very niche bug when trying things out locally. There is one case I've found where minimization doesn't occur, when it should.
To reproduce, run the target in #48320 with
go test -run Fuzz -fuzz Fuzz -v
. This happens consistently whenever there is something in the interesting cache and when-parallel
is greater than 1.Using the debugger, I was able to narrow it down to this scenario:
While fuzzing, an input which expands coverage is found. When minimizing said input, a new crash occurs. Currently, minimization is shut off if a crash is found during minimization
The text was updated successfully, but these errors were encountered: