Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: apparent infinite expansion of recursive function #48711

Closed
findleyr opened this issue Oct 1, 2021 · 5 comments
Closed

cmd/compile: apparent infinite expansion of recursive function #48711

findleyr opened this issue Oct 1, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.18

Comments

@findleyr
Copy link
Contributor

findleyr commented Oct 1, 2021

The following program type-checks, but appears to grow unbounded during compilation:

package main

func f[T interface{~[]P}, P any](t T) {
	if t == nil {
		return
	}
	f[[]T,T]([]T{t})
}

func main() {
	f[[]int](nil)
}

This is not surprising: the program was constructed to require an infinitely growing number of function instances. See also #48098 and #48703: infinitely expanding instances are generally problematic.

Not sure where it is best to handle this. It seems like something that could be detected by the type-checker, but there can be an arbitrary number of functions involved in this infinite expansion. Maybe it would be easier for the compiler to enforce a limit on recursive instantiation.

CC @griesemer @danscales @randall77 @timothy-king
@findleyr findleyr added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Oct 1, 2021
@findleyr findleyr added this to the Go1.18 milestone Oct 1, 2021
@danscales
Copy link
Contributor

This is pretty similar to #48018 , which I am planning to fix by having a limit on the depth or number of instantiations for the same function/method. This case should be handled by the same fix that I add for #48018.

(Both this case and #48018 could possibly be handled if we computed some/all dictionaries and type descriptors at run time, but we compute all dictionaries at compile time and don't want to change that.)

@findleyr
Copy link
Contributor Author

findleyr commented Oct 1, 2021

Thanks, please feel free to close this as a dupe of #48018 if that would be helpful, I missed that in my search for dupes. They might be slightly different but I agree that the fix should probably be the same.

Interestingly I see that @griesemer and I both suggested that the type checker could/should detect this, but I think that might be overly optimistic. Detecting this would require a lot more machinery than we currently have.

This came up because @timothy-king and I were talking about recursive instantiation. go/ssa will need a similar limit.

@findleyr findleyr mentioned this issue Oct 1, 2021
Closed
@findleyr findleyr mentioned this issue Oct 8, 2021
Closed
@ALTree ALTree mentioned this issue Oct 13, 2021
Closed
@toothrot
Copy link
Contributor

Friendly ping that this is a release-blocking issue for Go 1.18.

@griesemer
Copy link
Contributor

CL addressing this is in progress.
cc: @mdempsky

@gopherbot
Copy link

Change https://golang.org/cl/362394 mentions this issue: test: add regress test for reported non-monomorphizable example

@golang golang locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
5 participants
@toothrot @danscales @griesemer @gopherbot @findleyr