New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys/unix: TestSysvSharedMemory consistently failing on multiple builders #48708
Comments
Change https://golang.org/cl/353392 mentions this issue: |
Change https://golang.org/cl/353398 mentions this issue: |
Whether System V IPC is supported is a kernel configuration. For golang/go#48708 Change-Id: Id0d23a5ede5f75f70ca6bb0b8abaec773b6adc74 Reviewed-on: https://go-review.googlesource.com/c/sys/+/353392 Trust: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
I believe the combination of 353392 and 353398 should address the test failures. However, I don't really understand the IPC_64 thing in 353398... if there was someone else who understood linux syscalls a bit better then a better fix could be made. |
I am a bit surprised that the tests didn't fail on my original commit in gerrit, but I assume it was just that it didn't run on all the architectures? I do think I've identified what's going on here now, and I'll push a better fix soon I hope. After Linux 5.1, a bunch of architectures got SYS_SHMxxx syscalls (torvalds/linux@0d6040d). However, prior to that they only supported using the SYS_IPC entrypoint. Looking through glibc's source, it doesn't bother trying to detect this at compile time, instead there are two different macros In
And in
It appears that
|
For golang/go#48708 Change-Id: Ieb5fdb5eb571af836268b69d3f1066ef8497a7b7 GitHub-Last-Rev: 59e24d8 GitHub-Pull-Request: #118 Reviewed-on: https://go-review.googlesource.com/c/sys/+/353398 Trust: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Looks like the builder failures have indeed cleared. |
TestSysvSharedMemory
, added for #46084 in CL 327830, is consistently failing on several of thelinux
builders for less-common architectures:It isn't obvious to me whether we expect
SysvShmGet
to work on those platforms. If not, the test should callSkip
on platforms / kernels on which it is not supported.Since these builders are consistently failing (and thus not providing useful feedback about other changes), this fix needs to happen soon — either by fixing the test, adding skips, or reverting CL 327830 until someone has more time to fix it.
CC @tklauser @virtuald
greplogs --dashboard -md -l -e 'FAIL: TestSysvSharedMemory'
2021-09-30T14:19:18-969570c/04242ac/linux-ppc64le-buildlet
2021-09-30T14:19:18-969570c/04242ac/linux-ppc64le-power9osu
2021-09-30T14:19:18-969570c/04242ac/linux-s390x-ibm
2021-09-30T14:19:18-969570c/205640e/linux-mips64-rtrk
2021-09-30T14:19:18-969570c/205640e/linux-ppc64le-buildlet
2021-09-30T14:19:18-969570c/205640e/linux-ppc64le-power9osu
2021-09-30T14:19:18-969570c/205640e/linux-s390x-ibm
2021-09-30T14:19:18-969570c/6b0026a/linux-ppc64le-buildlet
2021-09-30T14:19:18-969570c/6b0026a/linux-ppc64le-power9osu
2021-09-30T14:19:18-969570c/6b0026a/linux-s390x-ibm
2021-09-30T14:19:18-969570c/7162c4c/linux-mips64le-mengzhuo
2021-09-30T14:19:18-969570c/7162c4c/linux-ppc64le-buildlet
2021-09-30T14:19:18-969570c/7162c4c/linux-ppc64le-power9osu
2021-09-30T14:19:18-969570c/7162c4c/linux-s390x-ibm
2021-09-30T14:19:18-969570c/7d57324/linux-ppc64le-buildlet
2021-09-30T14:19:18-969570c/7d57324/linux-ppc64le-power9osu
2021-09-30T14:19:18-969570c/7d57324/linux-s390x-ibm
2021-09-30T14:19:18-969570c/9112d29/linux-mips64-rtrk
2021-09-30T14:19:18-969570c/9112d29/linux-mips64le-mengzhuo
2021-09-30T14:19:18-969570c/9112d29/linux-ppc64le-buildlet
2021-09-30T14:19:18-969570c/9112d29/linux-ppc64le-power9osu
2021-09-30T14:19:18-969570c/9112d29/linux-s390x-ibm
2021-09-30T14:19:18-969570c/b043d23/linux-mips64le-mengzhuo
2021-09-30T14:19:18-969570c/b043d23/linux-ppc64le-buildlet
2021-09-30T14:19:18-969570c/b043d23/linux-ppc64le-power9osu
2021-09-30T14:19:18-969570c/b043d23/linux-s390x-ibm
2021-09-30T14:19:18-969570c/bd8009d/linux-mips64-rtrk
2021-09-30T14:19:18-969570c/bd8009d/linux-mips64le-mengzhuo
2021-09-30T14:19:18-969570c/bd8009d/linux-ppc64le-buildlet
2021-09-30T14:19:18-969570c/bd8009d/linux-ppc64le-power9osu
2021-09-30T14:19:18-969570c/bd8009d/linux-s390x-ibm
2021-09-30T14:19:18-969570c/d4aed7e/linux-mips64le-mengzhuo
2021-09-30T14:19:18-969570c/d4aed7e/linux-s390x-ibm
The text was updated successfully, but these errors were encountered: