Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/api: update for generics #48706

Closed
findleyr opened this issue Sep 30, 2021 · 1 comment
Closed

cmd/api: update for generics #48706

findleyr opened this issue Sep 30, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@findleyr
Copy link
Contributor

cmd/api needs to be updated for generics. For example, this is what it currently outputs for the constraints package:

pkg constraints, type Chan interface {}
pkg constraints, type Complex interface {}
pkg constraints, type Float interface {}
pkg constraints, type Integer interface {}
pkg constraints, type Map interface {}
pkg constraints, type Ordered interface {}
pkg constraints, type Signed interface {}
pkg constraints, type Slice interface {}
pkg constraints, type Unsigned interface {}

It also looks like it could panic on a generic type declaration. I don't think this will be particularly tricky, but it is a release-blocker.

I am happy to make this change, though if anyone else wants to take it this would be a good opportunity to use the new go/ast and go/types APIs.

@findleyr findleyr added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Sep 30, 2021
@findleyr findleyr added this to the Go1.18 milestone Sep 30, 2021
@gopherbot
Copy link

Change https://golang.org/cl/354612 mentions this issue: cmd/api: support type parameters

@golang golang locked and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Development

No branches or pull requests

2 participants