Skip to content

archive/tar: failure in TestFileInfoHeaderDir when source tree is setgid #4867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 21, 2013 · 6 comments
Closed

archive/tar: failure in TestFileInfoHeaderDir when source tree is setgid #4867

gopherbot opened this issue Feb 21, 2013 · 6 comments
Labels
FrozenDueToAge
Milestone
Go1.1

Comments

@gopherbot
Copy link
Contributor

by Lytvynov.A.V:

What steps will reproduce the problem?

1. checkout tip revision
2. run "go test archive/tar"

What is the expected output?

ok      archive/tar time_taken

What do you see instead?

--- FAIL: TestFileInfoHeaderDir (0.00 seconds)
tar_test.go:52:     Mode = 042755; want 040755
FAIL
FAIL    archive/tar 0.008s

Which operating system are you using?

Debian Wheezy with latest liquorix kernel (amd64) 

Which version are you using?  (run 'go version')

go version devel +3391481b6373 Wed Feb 20 22:15:36 2013 -0800 linux/amd64
@remyoudompheng
Copy link
Contributor

Comment 1:

Do you use ACLs or setgid on the directory where you host Go source code?
The test does not expect that.

@gopherbot
Copy link
Contributor Author

Comment 2 by Lytvynov.A.V:

I didn't do anything like that, maybe the system did it automatically.
How can I check that?
Test fails both under root and normal user.
root is owner of all the stdlib's code tree.

@remyoudompheng
Copy link
Contributor

Comment 3:

What are the permissions on $GOROOT/src/pkg/archive/tar/testdata ?
You can use the stat command for detailed information.

@gopherbot
Copy link
Contributor Author

Comment 4 by Lytvynov.A.V:

File: `/usr/local/go/src/pkg/archive/tar/testdata'
  Size: 4096        Blocks: 8          IO Block: 4096   directory
Device: 805h/2053d  Inode: 525136      Links: 2
Access: (2755/drwxr-sr-x)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2013-02-21 14:50:51.127605377 +0200
Modify: 2013-02-21 14:09:17.241897545 +0200
Change: 2013-02-21 14:39:20.530003788 +0200
 Birth: -

@bradfitz
Copy link
Contributor

Comment 6:

https://golang.org/cl/7382045/

Status changed to Started.

@bradfitz
Copy link
Contributor

Comment 7:

This issue was closed by revision 4335e69.

Status changed to Fixed.

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
4 participants
@bradfitz @rsc @remyoudompheng @gopherbot