Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: TestTransportPingWhenReading failures with "client: http2: client connection lost" #48668

Closed
bcmills opened this issue Sep 28, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 28, 2021

--- FAIL: TestTransportPingWhenReading (1.30s)
    --- FAIL: TestTransportPingWhenReading/two_pings (0.36s)
        transport_test.go:775: client: http2: client connection lost
FAIL
FAIL	golang.org/x/net/http2	24.375s

This failure mode is part (but not all) of the failure mode reported in #42514. It appears that CL 269797 fixed the "expected … got” comparison, but not the “client connection lost” error.

CC @fraenkel @neild


greplogs --dashboard -md -l -e 'client: http2: client connection lost' --since=2021-02-23

2021-09-17T22:17:30-978cfad/30faf96/freebsd-arm64-dmgk
2021-09-17T22:17:30-978cfad/48cf96c/freebsd-arm-paulzhol
2021-09-17T22:17:30-978cfad/91c2318/android-amd64-emu
2021-09-17T22:17:30-978cfad/dc5b1d3/android-amd64-emu
2021-09-17T16:35:49-3c21e5b/552410f/netbsd-arm-bsiegert
2021-09-16T01:41:20-12bc252/6602c86/freebsd-arm-paulzhol
2021-09-16T01:41:20-12bc252/6d02ce8/freebsd-arm64-dmgk
2021-09-16T01:41:20-12bc252/cfa233d/freebsd-arm-paulzhol
2021-09-13T18:02:22-943fd67/0edc6c4/freebsd-arm64-dmgk
2021-09-13T18:02:22-943fd67/4847c47/freebsd-arm-paulzhol
2021-09-13T18:02:22-943fd67/e79c297/freebsd-arm64-dmgk
2021-09-08T19:18:46-a5e0955/23832ba/android-386-emu
2021-09-03T16:21:42-ad29c8a/903958d/freebsd-arm64-dmgk
2021-09-02T16:59:21-8d99171/8226cb0/linux-ppc64-buildlet
2021-08-13T16:08:13-60bc85c/8eeb1bf/freebsd-arm-paulzhol
2021-07-26T21:34:35-c6fcb2d/37c117f/darwin-amd64-11_0
2021-07-26T21:34:35-c6fcb2d/818c5f6/freebsd-arm64-dmgk
2021-07-26T21:34:35-c6fcb2d/acbe242/linux-ppc64le-buildlet
2021-07-26T21:34:35-c6fcb2d/b8ca6e5/freebsd-arm-paulzhol
2021-07-16T20:39:47-853a461/849b791/freebsd-arm64-dmgk
2021-07-16T20:39:47-853a461/ed8cbbc/freebsd-arm-paulzhol
2021-06-14T18:27:18-04defd4/69728ea/freebsd-arm64-dmgk
2021-06-14T18:27:18-04defd4/a91ed83/illumos-amd64
2021-06-14T18:27:18-04defd4/c1cc9f9/freebsd-arm-paulzhol
2021-06-10T13:23:58-84b48f8/14305bf/freebsd-arm-paulzhol
2021-06-10T13:23:58-84b48f8/24cff0f/freebsd-arm64-dmgk
2021-06-10T13:23:58-84b48f8/67b1b6a/freebsd-arm64-dmgk
2021-06-10T12:43:26-52da8fb/ab7f829/freebsd-arm-paulzhol
2021-05-25T06:32:56-abc4532/182157c/freebsd-arm-paulzhol
2021-05-25T06:32:56-abc4532/ab7f829/freebsd-arm-paulzhol
2021-05-21T19:59:47-fe42d45/217f5dd/freebsd-arm-paulzhol
2021-05-21T19:59:47-fe42d45/3c65644/freebsd-arm-paulzhol
2021-05-21T19:59:47-fe42d45/9636878/illumos-amd64
2021-05-21T19:59:47-fe42d45/cca23a7/freebsd-arm-paulzhol
2021-05-10T12:01:50-4163338/44a6805/android-386-emu
2021-05-10T12:01:50-4163338/44a6805/android-amd64-emu
2021-05-10T12:01:50-4163338/44a6805/linux-ppc64-buildlet
2021-05-10T12:01:50-4163338/a8d8591/freebsd-arm-paulzhol
2021-05-10T12:01:50-4163338/bfe3573/freebsd-arm-paulzhol
2021-05-10T12:01:50-4163338/freebsd-arm64-dmgk
2021-05-10T12:01:50-4163338/netbsd-arm-bsiegert
2021-05-10T09:51:57-81045d8/07d8cba/freebsd-arm-paulzhol
2021-05-08T05:16:33-16afe75/4c8f48e/freebsd-arm-paulzhol
2021-05-08T05:16:33-16afe75/603f43c/freebsd-arm-paulzhol
2021-05-08T05:16:33-16afe75/b38b1b2/freebsd-arm-paulzhol
2021-05-08T05:16:33-16afe75/bedf2c4/freebsd-arm-paulzhol
2021-05-08T05:16:33-16afe75/c14ecac/freebsd-arm-paulzhol
2021-05-05T21:49:59-0714010/4dbad79/freebsd-arm-paulzhol
2021-05-05T21:49:59-0714010/832c70e/freebsd-arm-paulzhol
2021-05-05T21:49:59-0714010/af6123a/freebsd-arm-paulzhol
2021-05-05T21:49:59-0714010/d80d142/linux-ppc64le-buildlet
2021-05-05T21:49:59-0714010/f5423ea/freebsd-arm-paulzhol
2021-05-05T02:47:14-0287a6f/4c97912/freebsd-arm-paulzhol
2021-05-05T02:47:14-0287a6f/69368ce/linux-ppc64le-buildlet
2021-05-05T02:47:14-0287a6f/ba7cac4/linux-ppc64-buildlet
2021-05-05T02:47:14-0287a6f/c0a7ecf/aix-ppc64
2021-05-05T02:47:14-0287a6f/c0a7ecf/freebsd-arm-paulzhol
2021-05-04T13:21:25-bbd867f/62d424d/freebsd-arm-paulzhol
2021-05-04T13:21:25-bbd867f/ea0537f/linux-ppc64le-power9osu
2021-05-03T06:03:51-7fd8e65/138d2c9/freebsd-arm-paulzhol
2021-05-03T06:03:51-7fd8e65/169155d/android-amd64-emu
2021-05-03T06:03:51-7fd8e65/2422c5e/freebsd-arm64-dmgk
2021-05-03T06:03:51-7fd8e65/496d7c6/freebsd-arm64-dmgk
2021-05-03T06:03:51-7fd8e65/ddb648f/android-amd64-emu
2021-05-02T03:00:24-e590880/053fe2f/freebsd-arm-paulzhol
2021-05-01T22:26:12-f8dd838/72ccabc/freebsd-arm-paulzhol
2021-05-01T14:20:56-aec3718/72ccabc/freebsd-arm-paulzhol
2021-05-01T14:20:56-aec3718/879db69/freebsd-arm-paulzhol
2021-04-28T14:07:49-89ef3d9/22a56b6/freebsd-arm64-dmgk
2021-04-28T14:07:49-89ef3d9/72ccabc/android-386-emu
2021-04-28T14:07:49-89ef3d9/8e91458/freebsd-arm-paulzhol
2021-04-28T14:07:49-89ef3d9/9c72078/freebsd-arm-paulzhol
2021-04-27T23:12:57-85d9c07/92d1afe/freebsd-arm64-dmgk
2021-04-27T23:12:57-85d9c07/9726c78/android-amd64-emu
2021-04-23T18:45:38-5f58ad6/e0815d0/freebsd-arm-paulzhol
2021-04-23T18:45:38-5f58ad6/f12cf76/android-amd64-emu
2021-04-23T17:40:36-e997de6/06c9756/android-386-emu
2021-04-23T17:40:36-e997de6/d2f96f2/freebsd-arm-paulzhol
2021-04-21T23:01:15-4e50805/14056d0/linux-ppc64-buildlet
2021-04-21T23:01:15-4e50805/1b0a031/linux-ppc64-buildlet
2021-04-21T22:37:29-2554d15/06c9756/android-amd64-emu
2021-04-21T22:37:29-2554d15/06c9756/linux-ppc64-buildlet
2021-04-20T21:01:06-798c215/381252f/android-amd64-emu
2021-04-20T21:01:06-798c215/c33ced6/freebsd-arm-paulzhol
2021-04-20T21:01:06-798c215/c33ced6/linux-ppc64-buildlet
2021-04-20T21:01:06-798c215/f53c2fa/freebsd-arm-paulzhol
2021-04-20T07:25:03-d25e304/06c9756/freebsd-arm-paulzhol
2021-04-20T07:25:03-d25e304/fe26dfa/freebsd-arm-paulzhol
2021-04-15T23:10:46-e915ea6/6b8e3e2/illumos-amd64
2021-04-15T23:10:46-e915ea6/a72622d/freebsd-arm-paulzhol
2021-04-14T19:42:28-0645797/083a26c/linux-ppc64le-buildlet
2021-04-14T19:42:28-0645797/7ad496b/freebsd-arm-paulzhol
2021-04-10T08:11:32-afb366f/58fdac0/linux-ppc64le-buildlet
2021-04-10T08:11:32-afb366f/eb433ed/freebsd-arm-paulzhol
2021-04-05T18:03:19-a5a99cb/519f223/android-amd64-emu
2021-03-31T21:22:08-0fccb6f/776d8d3/freebsd-arm-paulzhol
2021-03-31T21:22:08-0fccb6f/8c163e8/dragonfly-amd64-5_8
2021-03-31T21:22:08-0fccb6f/8c163e8/freebsd-arm64-dmgk
2021-03-31T21:22:08-0fccb6f/9baddd3/freebsd-arm64-dmgk
2021-03-31T21:22:08-0fccb6f/a1e4657/freebsd-arm-paulzhol
2021-03-31T21:22:08-0fccb6f/dac136f/freebsd-arm-paulzhol
2021-03-31T21:22:08-0fccb6f/fe587ce/freebsd-arm-paulzhol
2021-03-31T06:09:03-cb1fcc7/135c9f4/freebsd-arm-paulzhol
2021-03-30T23:05:44-e572328/135c9f4/android-amd64-emu
2021-03-30T23:05:44-e572328/c77418f/linux-ppc64le-buildlet
2021-03-30T21:00:36-cd0ac97/c77418f/linux-ppc64le-buildlet
2021-03-30T14:28:15-c8897c2/6df5d3a/freebsd-arm64-dmgk
2021-03-30T14:28:15-c8897c2/e4a4161/freebsd-arm-paulzhol
2021-03-30T07:57:24-22f4162/a81b5e4/freebsd-arm-paulzhol
2021-03-29T18:18:59-df645c7/4e16422/linux-mipsle-rtrk
2021-03-26T22:08:55-61e0566/565e70f/illumos-amd64
2021-03-26T06:03:03-6b15177/7c88ae4/linux-ppc64le-buildlet
2021-03-26T06:03:03-6b15177/98a9023/android-amd64-emu
2021-03-24T20:56:30-d1beb07/0fc595e/aix-ppc64
2021-03-24T20:56:30-d1beb07/5cec8b8/android-amd64-emu
2021-03-24T20:56:11-3061449/dade83a/dragonfly-amd64-5_8
2021-03-24T05:16:36-2c4c8ec/771c57e/android-amd64-emu
2021-03-24T05:16:36-2c4c8ec/dcffdac/android-amd64-emu
2021-03-23T14:18:57-08027d5/14ef2d8/darwin-amd64-10_15
2021-03-23T14:18:57-08027d5/4357f71/aix-ppc64
2021-03-23T14:18:57-08027d5/53dd0d7/freebsd-arm-paulzhol
2021-03-23T14:18:57-08027d5/87a3ac5/aix-ppc64
2021-03-23T14:18:57-08027d5/f39c4de/freebsd-arm-paulzhol
2021-03-16T09:26:52-d523dce/5437b5a/linux-ppc64-buildlet
2021-03-16T09:26:52-d523dce/a93849b/android-386-emu
2021-03-16T09:26:52-d523dce/f4b9183/freebsd-arm-paulzhol
2021-03-16T09:26:52-d523dce/freebsd-arm64-dmgk
2021-03-16T09:26:52-d523dce/linux-mipsle-rtrk
2021-03-15T17:06:53-34ac3e1/051bf37/freebsd-arm-paulzhol
2021-03-15T17:06:53-34ac3e1/15f1670/illumos-amd64
2021-03-15T17:06:53-34ac3e1/cc4e616/android-386-emu
2021-02-26T17:20:49-e18ecbb/4bd4dfe/freebsd-arm-paulzhol
2021-02-26T17:20:49-e18ecbb/86bbf4b/illumos-amd64
2021-02-26T17:20:49-e18ecbb/d0d38f0/android-amd64-emu
2021-02-26T17:20:49-e18ecbb/d0d38f0/freebsd-arm-paulzhol
2021-02-26T17:20:49-e18ecbb/dcffdac/android-amd64-emu
2021-02-26T17:20:49-e18ecbb/dragonfly-amd64
2021-02-26T10:14:13-39120d0/023c466/linux-ppc64-buildlet
2021-02-26T10:14:13-39120d0/30357d6/freebsd-arm64-dmgk
2021-02-24T08:20:22-3d97a24/023c466/android-amd64-emu
2021-02-24T08:20:22-3d97a24/7fcf989/freebsd-arm-paulzhol
2021-02-24T08:20:22-3d97a24/e25040d/freebsd-arm-paulzhol

@bcmills
Copy link
Contributor Author

bcmills commented Sep 28, 2021

Given the relatively high failure rate (14 failures since the start of this month), I think this is a release-blocker via #11811.

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Sep 28, 2021
@bcmills bcmills added this to the Go1.18 milestone Sep 28, 2021
@fraenkel
Copy link
Contributor

Our timeouts are too tight which is causing the PingTimeout to trip.

@gopherbot
Copy link

Change https://golang.org/cl/352970 mentions this issue: http2: increase PingTimeout for TestTransportPingWhenReading

dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
Use the default PingTimeout since it has no bearing on the test. A small
value can cause a failure on slower machines. Rely on the deadline to
determine a sufficient amount of time to complete.

Fixes golang/go#48668

Change-Id: I9389777fa00ed5193f1fc7ae04d2e2134114c675
Reviewed-on: https://go-review.googlesource.com/c/net/+/352970
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Bryan C. Mills <bcmills@google.com>
Trust: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants