Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: add a test for coverage guidance while fuzzing #48654

Closed
katiehockman opened this issue Sep 27, 2021 · 2 comments
Closed

cmd/go: add a test for coverage guidance while fuzzing #48654

katiehockman opened this issue Sep 27, 2021 · 2 comments
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.18

Comments

@katiehockman
Copy link
Contributor

There are currently no tests today that can verify any potential regressions in the coverage guidance while fuzzing. For example, https://go-review.googlesource.com/c/go/+/351316 was merged which caused a major regression and removed ~all coverage guidance with go test -fuzz, but there weren't any tests that could catch this.

One tricky part of writing a test like this will be to avoid flakiness.

/cc @golang/fuzzing
@katiehockman katiehockman added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker fuzz Issues related to native fuzzing support labels Sep 27, 2021
@katiehockman katiehockman added this to the Go1.18 milestone Sep 27, 2021
@katiehockman katiehockman added the Testing An issue that has been verified to require only test changes, not just a test failure. label Sep 28, 2021
@toothrot
Copy link
Contributor

Friendly ping that this issue is marked as a release-blocker for Go 1.18.

@katiehockman katiehockman added the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Oct 20, 2021
@katiehockman katiehockman removed release-blocker okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Nov 10, 2021
@gopherbot
Copy link

Change https://golang.org/cl/375736 mentions this issue: cmd/go: add fuzzing coverage test

jproberts pushed a commit to jproberts/go that referenced this issue Jun 21, 2022
@rolandshoemaker @jproberts
cmd/go: add fuzzing coverage test
9a7ed57 
Adds a test script for fuzzing coverage instrumentation.

Fixes golang#48654

Change-Id: Ieea7b4146bd5581baae869441cc1c652dd7485f5
Reviewed-on: https://go-review.googlesource.com/c/go/+/375736
Trust: Katie Hockman <katie@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
Trust: Roland Shoemaker <roland@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Go Security
Status: No status
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@toothrot @rolandshoemaker @gopherbot @katiehockman