Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: if (*ClientConn).encodeHeaders returns an error, roundTrip doesn't clean up streams map, etc #48652

Open
bradfitz opened this issue Sep 27, 2021 · 1 comment
Open

x/net/http2: if (*ClientConn).encodeHeaders returns an error, roundTrip doesn't clean up streams map, etc #48652

bradfitz opened this issue Sep 27, 2021 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

If you send try to RoundTrip a bogus request that trips up (*ClientConn).encodeHeaders, the (*ClientConn).roundTrip function returns without cleaning up the cc.streams map, etc.

/cc @neild
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 4, 2021
@mknyszek mknyszek added this to the Backlog milestone Oct 4, 2021
@mknyszek
Copy link
Contributor

mknyszek commented Oct 4, 2021

CC @neild

@mknyszek mknyszek modified the milestones: Backlog, Unreleased Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bradfitz @mknyszek