Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: cgo testCthread fails on ARM #4863

Closed
rsc opened this issue Feb 21, 2013 · 6 comments
Closed

runtime: cgo testCthread fails on ARM #4863

rsc opened this issue Feb 21, 2013 · 6 comments
Labels
FrozenDueToAge
Milestone
Go1.1

Comments

@rsc
Copy link
Contributor

rsc commented Feb 21, 2013 

misc/cgo/test's testCthread skips the test on ARM. The test breaks if run. It appears
that cgo_load_gm is not doing its job, or perhaps cgo_save_gm is not. Really I have no
idea. I spent a few hours on it and got nowhere. We need to fix this for Go 1.1.
@adg
Copy link
Contributor

adg commented Apr 9, 2013

Comment 1:

Is cgo on ARM using the old cgo system? If so, is this not a 1.1 issue? Ian, please
advise.

@ianlancetaylor
Copy link
Member

Comment 2:

I don't think this has anything do with the change to the way cgo works (you are correct
that ARM was not changed).  This is most likely a bug in the ARM code in runtime/cgo.
Personally I'm OK with not fixing this for Go 1.1, but then I don't use the ARM.  I
would imagine that this didn't work in 1.0.3 either.

@dsymonds
Copy link
Contributor

Comment 3:

Labels changed: added go1.1maybe, removed go1.1.

@minux
Copy link
Member

minux commented Apr 29, 2013

Comment 4:

i got some trail for this issue.
during the callback call in addThread(), runtime.cgocallbackg is called with the
following arguments:
 fn = 0x0, arg = 0x0, argsize = 314380
obviously incorrect. perhaps we can fix this before Go 1.1.

@minux
Copy link
Member

minux commented Apr 29, 2013

Comment 5:

https://golang.org/cl/9019043

Labels changed: added go1.1, removed go1.1maybe.

Owner changed to @minux.

Status changed to Started.

@minux
Copy link
Member

minux commented Apr 29, 2013

Comment 6:

This issue was closed by revision 5b78cee.

Status changed to Fixed.

@rsc rsc added fixed labels Apr 29, 2013
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
6 participants
@dsymonds @rsc @minux @ianlancetaylor @adg @gopherbot