Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unicode: update to version 14.0 #48621

Closed
180909 opened this issue Sep 25, 2021 · 5 comments
Closed

unicode: update to version 14.0 #48621

180909 opened this issue Sep 25, 2021 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@180909
Copy link
Contributor

180909 commented Sep 25, 2021 •
edited

What version of Go are you using (go version)?

$ go version
go version go1.17.1 darwin/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/Users/wangjiahua/go/bin"
GOCACHE="/Users/wangjiahua/Library/Caches/go-build"
GOENV="/Users/wangjiahua/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/wangjiahua/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/wangjiahua/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.17.1"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/vj/b75wqh2n5l324xzv_88g14vm0000gn/T/go-build2079872506=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.17.1 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.17.1
uname -v: Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X86_64
ProductName:	macOS
ProductVersion:	11.6
BuildVersion:	20G165
lldb --version: lldb-1300.0.32.2
Swift version 5.5-dev

What did you do?

https://play.golang.org/p/9biSMo4sTqo

What did you expect to see?

13.0.0

What did you see instead?

14.0.0
@ALTree ALTree added this to the Go1.18 milestone Sep 25, 2021
@mvdan mvdan changed the title src/unicode: update unicode to 14.0 unicode: update to version 14.0 Sep 25, 2021
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 4, 2021
@mknyszek
Copy link
Contributor

mknyszek commented Oct 4, 2021

CC @robpike via https://dev.golang.org/owners, but since that's dated, @rsc, maybe?

@robpike robpike mentioned this issue Oct 24, 2021
Closed
@TimothyGu TimothyGu mentioned this issue Nov 5, 2021
Open
@thanm thanm modified the milestones: Go1.18, Backlog Nov 10, 2021
@thanm
Copy link
Contributor

thanm commented Nov 10, 2021

This issue is currently in the Go 1.18 milestone -- given that we are in the freeze and we don't have any CLs for it, I think it probably makes sense to move it out of the 1.18 milestone. Please comment if this is a problem, thanks.

@golightlyb golightlyb mentioned this issue Sep 14, 2022
Closed
CyrilBrulebois added a commit to CyrilBrulebois/go-textseg that referenced this issue Oct 7, 2022
@CyrilBrulebois
Mark Go 1.17, 1.18, and 1.19 as using Unicode 13.
53dcfee 
Issues upstream:
 - “unicode: update to version 14.0” (golang/go#48621)
 - “unicode: update to version 15.0” (golang/go#55079)

At the moment, Unicode 15 is on the roadmap for Go 1.20, while Go 1.19
is confirmed to still be using Unicode 13 (e.g. on Debian unstable and
Debian testing).
CyrilBrulebois added a commit to CyrilBrulebois/go-textseg that referenced this issue Oct 7, 2022
@CyrilBrulebois
Mark Go 1.17, 1.18, and 1.19 as using Unicode 13.
21a91c5 
Issues upstream:
 - unicode: update to version 14.0
    → golang/go#48621
 - unicode: update to version 15.0
    → golang/go#55079

At the moment, Unicode 15 is on the roadmap for Go 1.20, while Go 1.19
is confirmed to still be using Unicode 13 (e.g. on Debian unstable and
Debian testing).
CyrilBrulebois added a commit to CyrilBrulebois/go-textseg that referenced this issue Oct 7, 2022
@CyrilBrulebois
autoversion: Mark Go 1.17, 1.18, and 1.19 as using Unicode 13.
726865a 
Issues upstream:
 - unicode: update to version 14.0
    → golang/go#48621
 - unicode: update to version 15.0
    → golang/go#55079

At the moment, Unicode 15 is on the roadmap for Go 1.20, while Go 1.19
is confirmed to still be using Unicode 13 (e.g. on Debian unstable and
Debian testing).
@weebney weebney mentioned this issue Dec 12, 2022
Closed
@gopherbot
Copy link

Change https://go.dev/cl/456836 mentions this issue: all: upgrade Unicode from 13.0.0 to 15.0.0

@weebney weebney mentioned this issue Dec 12, 2022
Closed
gopherbot pushed a commit that referenced this issue Feb 6, 2023
@weebney @robpike
all: upgrade Unicode from 13.0.0 to 15.0.0
def0be5 
Update unicode/tables.go to reflect changes in the Unicode Standard up to
Unicode 15.0.0, released 13 Sept 2022.

In order to accommodate this update, strconv/isPrint has been updated to
reflect changes in printable characters.

Also changed is template/exec_test.go for both text and html packages- in
the test "TestJSEscaping", rune U+FDFF was used as a placeholder for an
unprintable character. This codepoint was assigned and made printable in
Unicode 14.0.0, breaking this test. It has been replaced with the assigned
and never-printable U+FFFE to fix the test and provide resiliency in the
future.

This upgrade bypasses Unicode 14.0.0, but is compatible.

Updates #48621
Fixes #55079

Change-Id: I40efd097eb746db0727ebf7437280916d1242e47
GitHub-Last-Rev: c8885ca
GitHub-Pull-Request: #57265
Reviewed-on: https://go-review.googlesource.com/c/go/+/456837
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Rob Pike <r@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Rob Pike <r@golang.org>
johanbrandhorst pushed a commit to Pryz/go that referenced this issue Feb 12, 2023
@weebney @johanbrandhorst
all: upgrade Unicode from 13.0.0 to 15.0.0
636dbd7 
Update unicode/tables.go to reflect changes in the Unicode Standard up to
Unicode 15.0.0, released 13 Sept 2022.

In order to accommodate this update, strconv/isPrint has been updated to
reflect changes in printable characters.

Also changed is template/exec_test.go for both text and html packages- in
the test "TestJSEscaping", rune U+FDFF was used as a placeholder for an
unprintable character. This codepoint was assigned and made printable in
Unicode 14.0.0, breaking this test. It has been replaced with the assigned
and never-printable U+FFFE to fix the test and provide resiliency in the
future.

This upgrade bypasses Unicode 14.0.0, but is compatible.

Updates golang#48621
Fixes golang#55079

Change-Id: I40efd097eb746db0727ebf7437280916d1242e47
GitHub-Last-Rev: c8885ca
GitHub-Pull-Request: golang#57265
Reviewed-on: https://go-review.googlesource.com/c/go/+/456837
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Rob Pike <r@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Rob Pike <r@golang.org>
@dmitshur
Copy link
Contributor

Support for Unicode 15.0.0 (#55079) is now implemented, so there's nothing more to do in this issue. Please comment if I missed something.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2023
@gopherbot
Copy link

Change https://go.dev/cl/499618 mentions this issue: doc/go1.21: mention upgrade to Unicode 15.0.0

gopherbot pushed a commit that referenced this issue May 31, 2023
@ianlancetaylor @gopherbot
doc/go1.21: mention upgrade to Unicode 15.0.0
4406e8e 
For #48621
For #55079

Change-Id: I279b4fbf07d2fa9de9577559a4e17a57f5692aa3
Reviewed-on: https://go-review.googlesource.com/c/go/+/499618
Reviewed-by: Eli Bendersky <eliben@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Bypass: Ian Lance Taylor <iant@google.com>
apparentlymart pushed a commit to apparentlymart/go-textseg that referenced this issue Aug 29, 2023
@CyrilBrulebois @apparentlymart
autoversion: Mark Go 1.17, 1.18, and 1.19 as using Unicode 13.
45ed1d8 
Issues upstream:
 - unicode: update to version 14.0
    → golang/go#48621
 - unicode: update to version 15.0
    → golang/go#55079

At the moment, Unicode 15 is on the roadmap for Go 1.20, while Go 1.19
is confirmed to still be using Unicode 13 (e.g. on Debian unstable and
Debian testing).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@mknyszek @dmitshur @ALTree @gopherbot @thanm @180909