Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: NewSectionReader off+n overflow #48620

Closed
afq984 opened this issue Sep 25, 2021 · 1 comment
Closed

io: NewSectionReader off+n overflow #48620

afq984 opened this issue Sep 25, 2021 · 1 comment
Labels
FrozenDueToAge

Comments

@afq984
Copy link

afq984 commented Sep 25, 2021

What version of Go are you using (go version)?

$ go version
go version go1.17.1 linux/amd64

Does this issue reproduce with the latest release?

Y

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/afg984/.cache/go-build"
GOENV="/home/afg984/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/afg984/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/afg984/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17.1"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/afg984/void-battery/patcher/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2724258229=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Use NewSectionReader with math.MaxInt64

https://play.golang.org/p/2UftIzjKv1S

func main() {
	b := strings.NewReader("hello world")
	r := io.NewSectionReader(b, 6, math.MaxInt64)
	fmt.Println(io.ReadAll(r))
}

What did you expect to see?

[119 111 114 108 100] <nil>

gvisor does this: https://play.golang.org/p/RyEAyeKqvA5

https://github.com/google/gvisor/blob/2e25547e047f69dbfd24465459626351f8b22d55/pkg/secio/secio.go#L62

What did you see instead?

[] <nil>
@gopherbot
Copy link

Change https://golang.org/cl/352629 mentions this issue: io: avoid integer overflow in NewSectionReader

@golang golang locked and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afq984 @gopherbot