Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: unsafe.Add bug when adding uint8 value to a pointer [1.17 backport] #48561

Closed
gopherbot opened this issue Sep 22, 2021 · 3 comments
Closed

cmd/compile: unsafe.Add bug when adding uint8 value to a pointer [1.17 backport] #48561

gopherbot opened this issue Sep 22, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.2

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #48536 to be considered for backport to the next 1.17 minor release.

@gopherbot Please open a backport issue to Go 1.17.

This appears to be a bug in the implementation of unsafe.Add. This should be fixed to avoid silent miscompilation of valid code.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 22, 2021
@gopherbot gopherbot mentioned this issue Sep 22, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.2 milestone Sep 22, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/351593 mentions this issue: [release-branch.go1.17] cmd/compile: fix unsafe.Add with small-size offsets operands

@heschi heschi added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 6, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/354352 mentions this issue: [release-branch.go1.17] cmd/compile: fold handling OCONV logic to separate function

gopherbot pushed a commit that referenced this issue Oct 6, 2021
@cuonglm @ianlancetaylor
[release-branch.go1.17] cmd/compile: fold handling OCONV logic to sep…
b18ba59 
…arate function

So next CL can re-use the logic to perform checkptr instrumentation.

For #48561

Change-Id: I3241e9c3c84da04db71fd1d4fd83cb76b2e18521
Reviewed-on: https://go-review.googlesource.com/c/go/+/345435
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
(cherry picked from commit 8fad81c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/354352
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link
Author

Closed by merging b18ba59 to release-branch.go1.17.

@golang golang locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.2
Development

No branches or pull requests
2 participants
@gopherbot @heschi