Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: frequent failures with "panic: read from closed body" since 2021-09-13 #48555

Closed
bcmills opened this issue Sep 22, 2021 · 2 comments
Closed

x/net/http2: frequent failures with "panic: read from closed body" since 2021-09-13 #48555

bcmills opened this issue Sep 22, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 22, 2021 •
edited 

panic: read from closed body

goroutine 22485 [running]:
golang.org/x/net/http2.(*closeChecker).Read(0x90a07e0, {0x8fb4000, 0x80000, 0x80000})
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:4970 +0x90
golang.org/x/net/http2.(*clientStream).writeRequestBody(0x8e91130, {0x846636c, 0x90a07e0}, {0xaaa51b58, 0x90a07e0})
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport.go:1350 +0x502
golang.org/x/net/http2.(*Transport).getBodyWriterState.func1()
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport.go:2656 +0xa4
created by golang.org/x/net/http2.bodyWriterState.scheduleBodyWrite
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport.go:2705 +0x7c
FAIL	golang.org/x/net/http2	19.076s

greplogs --dashboard -md -l -e 'panic: read from closed body'

2021-09-17T22:17:30-978cfad/04572fa/linux-ppc64le-power9osu
2021-09-17T22:17:30-978cfad/085c609/windows-arm64-10
2021-09-17T22:17:30-978cfad/48cf96c/linux-ppc64-buildlet
2021-09-17T22:17:30-978cfad/552410f/linux-ppc64-buildlet
2021-09-17T22:17:30-978cfad/74ba70b/windows-arm64-10
2021-09-17T22:17:30-978cfad/abc4f09/linux-ppc64le-power9osu
2021-09-17T22:17:30-978cfad/dc5b1d3/windows-arm64-10
2021-09-17T22:17:30-978cfad/e128749/netbsd-amd64-9_0
2021-09-17T22:17:30-978cfad/e925c46/linux-ppc64-buildlet
2021-09-17T22:17:30-978cfad/e925c46/linux-ppc64le-power9osu
2021-09-17T16:35:49-3c21e5b/323c6f7/linux-ppc64-buildlet
2021-09-16T01:41:20-12bc252/04f5116/windows-arm64-10
2021-09-16T01:41:20-12bc252/14e812b/netbsd-arm64-bsiegert
2021-09-16T01:41:20-12bc252/4efdaa7/linux-ppc64le-buildlet
2021-09-16T01:41:20-12bc252/6d02ce8/android-amd64-emu
2021-09-16T01:41:20-12bc252/b1bedc0/windows-arm64-10
2021-09-16T01:41:20-12bc252/d09e09b/windows-arm64-10
2021-09-16T01:41:20-12bc252/e09dcc2/netbsd-amd64-9_0
2021-09-13T18:02:22-943fd67/21a4e67/netbsd-amd64-9_0
2021-09-13T18:02:22-943fd67/2da3375/windows-arm64-10
2021-09-13T18:02:22-943fd67/552410f/linux-ppc64-buildlet
2021-09-13T18:02:22-943fd67/72bb818/netbsd-386-9_0

CC @neild
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Sep 22, 2021
@bcmills bcmills added this to the Go1.18 milestone Sep 22, 2021
@neild neild self-assigned this Sep 22, 2021
@gopherbot
Copy link

Change https://golang.org/cl/351972 mentions this issue: http2: remove check for read-after-close of request bodies

@gopherbot
Copy link

Change https://golang.org/cl/356984 mentions this issue: http2: remove check for read-after-close of request bodies

dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
@neild
http2: remove check for read-after-close of request bodies
7f104e0 
Aborting a request currently races with writes of the request
body, so abortRequestBodyWrite can close the body before writeRequestBody
reads from it.

Fixes golang/go#48555.

Change-Id: I5362283f4066611aeecbc48b400d79cfa0b4b284
Reviewed-on: https://go-review.googlesource.com/c/net/+/351972
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@rsc rsc unassigned neild Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@neild @bcmills @gopherbot