Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/ipv6: TestIPPerInterfaceSinglePacketConnWithSingleGroupListener broken on freebsd-386 since mid-August #48553

Closed
bcmills opened this issue Sep 22, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD release-blocker
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 22, 2021

See previously #31221.

--- FAIL: TestIPPerInterfaceSinglePacketConnWithSingleGroupListener (0.00s)
    multicastlistener_test.go:247: listen ip6:ipv6-icmp 0:fe:8000::%lo0: bind: can't assign requested address
FAIL
FAIL	golang.org/x/net/ipv6	0.017s

greplogs --dashboard -md -l -e 'FAIL: TestIPPerInterfaceSinglePacketConnWithSingleGroupListener' --since=2019-05-01

2021-09-17T22:17:30-978cfad/04572fa/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/04572fa/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/051df0d/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/051df0d/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/085c609/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/085c609/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/09d3df0/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/09d3df0/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/2f70ce3/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/2f70ce3/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/30faf96/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/30faf96/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/3664950/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/3664950/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/48cf96c/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/48cf96c/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/55d22f7/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/55d22f7/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/74ba70b/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/74ba70b/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/91c2318/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/91c2318/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/98989f2/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/98989f2/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/ccf140f/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/ccf140f/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/dc5b1d3/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/dc5b1d3/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/e128749/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/e128749/freebsd-386-12_2
2021-09-17T22:17:30-978cfad/e925c46/freebsd-386-11_4
2021-09-17T22:17:30-978cfad/e925c46/freebsd-386-12_2
2021-09-17T21:38:27-95888ee/3fa7dbe/freebsd-386-11_4
2021-09-17T21:38:27-95888ee/3fa7dbe/freebsd-386-12_2
2021-09-17T16:35:49-3c21e5b/323c6f7/freebsd-386-12_2
2021-09-17T16:35:49-3c21e5b/6d02ce8/freebsd-386-11_4
2021-09-17T16:35:49-3c21e5b/6d02ce8/freebsd-386-12_2
2021-09-17T16:35:49-3c21e5b/70493b3/freebsd-386-11_4
2021-09-17T16:35:49-3c21e5b/70493b3/freebsd-386-12_2
2021-09-17T16:35:49-3c21e5b/974b016/freebsd-386-11_4
2021-09-17T16:35:49-3c21e5b/974b016/freebsd-386-12_2
2021-09-17T16:35:49-3c21e5b/cea7a71/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/04f5116/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/04f5116/freebsd-386-12_2
2021-09-16T01:41:20-12bc252/14e812b/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/14e812b/freebsd-386-12_2
2021-09-16T01:41:20-12bc252/48e2b1e/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/48e2b1e/freebsd-386-12_2
2021-09-16T01:41:20-12bc252/4efdaa7/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/4efdaa7/freebsd-386-12_2
2021-09-16T01:41:20-12bc252/6602c86/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/6602c86/freebsd-386-12_2
2021-09-16T01:41:20-12bc252/6d02ce8/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/6d02ce8/freebsd-386-12_2
2021-09-16T01:41:20-12bc252/8d2a9c3/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/8d2a9c3/freebsd-386-12_2
2021-09-16T01:41:20-12bc252/b1bedc0/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/b1bedc0/freebsd-386-12_2
2021-09-16T01:41:20-12bc252/bcdc61d/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/bcdc61d/freebsd-386-12_2
2021-09-16T01:41:20-12bc252/cfa233d/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/cfa233d/freebsd-386-12_2
2021-09-16T01:41:20-12bc252/d09e09b/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/d09e09b/freebsd-386-12_2
2021-09-16T01:41:20-12bc252/e09dcc2/freebsd-386-11_4
2021-09-16T01:41:20-12bc252/e09dcc2/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/03df68d/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/03df68d/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/0bb40b0/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/0edc6c4/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/0edc6c4/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/137543b/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/2933c45/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/2933c45/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/2da3375/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/2da3375/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/4847c47/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/4847c47/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/5b48fca/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/5b48fca/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/6196979/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/6196979/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/72bb818/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/72bb818/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/bf26e43/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/bf26e43/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/c7f2f51/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/c7f2f51/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/cfa233d/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/cfa233d/freebsd-386-12_2
2021-09-13T18:02:22-943fd67/e4dfd78/freebsd-386-11_4
2021-09-13T18:02:22-943fd67/e4dfd78/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/0d8a4bf/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/0d8a4bf/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/1a708bc/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/1a708bc/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/2091bd3/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/2091bd3/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/23832ba/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/23832ba/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/5a94a90/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/5a94a90/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/90c5660/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/90c5660/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/96ab854/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/96ab854/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/a50225a/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/a50225a/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/ad97d20/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/ad97d20/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/b32209d/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/b32209d/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/c3b217a/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/c3b217a/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/c69f5c0/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/c69f5c0/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/cf2fe5d/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/cf2fe5d/freebsd-386-12_2
2021-09-08T19:18:46-a5e0955/da1aa65/freebsd-386-11_4
2021-09-08T19:18:46-a5e0955/da1aa65/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/054710c/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/054710c/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/38c2e08/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/38c2e08/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/3fff213/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/3fff213/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/409434d/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/409434d/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/50c69cc/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/50c69cc/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/64bdad2/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/64bdad2/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/65f0d24/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/65f0d24/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/8214257/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/8214257/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/9295723/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/9295723/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/9581d89/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/963218c/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/963218c/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/b606739/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/b606739/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/bab79dd/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/bab79dd/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/c8d4fe2/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/c8d4fe2/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/d419f9c/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/d419f9c/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/da790cc/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/da790cc/freebsd-386-12_2
2021-09-07T22:56:31-ff17edf/f5bdbf3/freebsd-386-11_4
2021-09-07T22:56:31-ff17edf/f5bdbf3/freebsd-386-12_2
2021-09-07T21:54:12-f8bed21/a9a01a3/freebsd-386-11_4
2021-09-07T21:54:12-f8bed21/a9a01a3/freebsd-386-12_2
2021-09-07T21:54:12-f8bed21/dcf3545/freebsd-386-11_4
2021-09-07T21:54:12-f8bed21/dcf3545/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/20a71c9/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/20a71c9/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/21de6bc/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/21de6bc/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/23f4f0d/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/23f4f0d/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/2a48452/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/2a48452/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/6226020/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/6226020/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/6640171/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/6640171/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/7b69ddc/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/8078355/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/8078355/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/8118866/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/8118866/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/903958d/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/903958d/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/a193843/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/a193843/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/bca8c6f/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/bca8c6f/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/c7f09ee/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/c7f09ee/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/d92101f/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/d92101f/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/dcf3545/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/dcf3545/freebsd-386-12_2
2021-09-03T16:21:42-ad29c8a/ecfff58/freebsd-386-11_4
2021-09-03T16:21:42-ad29c8a/ecfff58/freebsd-386-12_2
2021-09-02T16:59:21-8d99171/065f380/freebsd-386-11_4
2021-09-02T16:59:21-8d99171/065f380/freebsd-386-12_2
2021-09-02T16:59:21-8d99171/17910ed/freebsd-386-11_4
2021-09-02T16:59:21-8d99171/17910ed/freebsd-386-12_2
2021-09-02T16:59:21-8d99171/52aef05/freebsd-386-11_4
2021-09-02T16:59:21-8d99171/52aef05/freebsd-386-12_2
2021-09-02T16:59:21-8d99171/7609b50/freebsd-386-11_4
2021-09-02T16:59:21-8d99171/7609b50/freebsd-386-12_2
2021-09-02T16:59:21-8d99171/9633195/freebsd-386-11_4
2021-09-02T16:59:21-8d99171/9633195/freebsd-386-12_2
2021-09-02T16:59:21-8d99171/9f69a44/freebsd-386-11_4
2021-09-02T16:59:21-8d99171/9f69a44/freebsd-386-12_2
2021-09-02T16:59:21-8d99171/a8aa6cf/freebsd-386-11_4
2021-09-02T16:59:21-8d99171/a8aa6cf/freebsd-386-12_2
2021-09-02T16:59:21-8d99171/ab7c904/freebsd-386-11_4
2021-09-02T16:59:21-8d99171/ab7c904/freebsd-386-12_2
2021-09-02T16:59:21-8d99171/acc2957/freebsd-386-11_4
2021-09-02T16:59:21-8d99171/acc2957/freebsd-386-12_2
2021-09-02T16:59:21-8d99171/ead3fe0/freebsd-386-11_4
2021-09-02T16:59:21-8d99171/ead3fe0/freebsd-386-12_2
2021-08-25T18:34:10-e898025/014a972/freebsd-386-11_4
2021-08-25T18:34:10-e898025/014a972/freebsd-386-12_2
2021-08-25T18:34:10-e898025/08588e6/freebsd-386-11_4
2021-08-25T18:34:10-e898025/08588e6/freebsd-386-12_2
2021-08-25T18:34:10-e898025/08e2519/freebsd-386-11_4
2021-08-25T18:34:10-e898025/08e2519/freebsd-386-12_2
2021-08-25T18:34:10-e898025/17e9d14/freebsd-386-11_4
2021-08-25T18:34:10-e898025/17e9d14/freebsd-386-12_2
2021-08-25T18:34:10-e898025/1ae7ddc/freebsd-386-11_4
2021-08-25T18:34:10-e898025/1ae7ddc/freebsd-386-12_2
2021-08-25T18:34:10-e898025/37d4532/freebsd-386-11_4
2021-08-25T18:34:10-e898025/4591f49/freebsd-386-11_4
2021-08-25T18:34:10-e898025/4591f49/freebsd-386-12_2
2021-08-25T18:34:10-e898025/4fb7956/freebsd-386-11_4
2021-08-25T18:34:10-e898025/4fb7956/freebsd-386-12_2
2021-08-25T18:34:10-e898025/6705191/freebsd-386-11_4
2021-08-25T18:34:10-e898025/6705191/freebsd-386-12_2
2021-08-25T18:34:10-e898025/782aa42/freebsd-386-11_4
2021-08-25T18:34:10-e898025/782aa42/freebsd-386-12_2
2021-08-25T18:34:10-e898025/840b429/freebsd-386-11_4
2021-08-25T18:34:10-e898025/840b429/freebsd-386-12_2
2021-08-25T18:34:10-e898025/90ed541/freebsd-386-11_4
2021-08-25T18:34:10-e898025/90ed541/freebsd-386-12_2
2021-08-25T18:34:10-e898025/d01388b/freebsd-386-11_4
2021-08-25T18:34:10-e898025/d01388b/freebsd-386-12_2
2021-08-25T18:34:10-e898025/d8b1567/freebsd-386-11_4
2021-08-25T18:34:10-e898025/d8b1567/freebsd-386-12_2
2021-08-25T18:34:10-e898025/ead3fe0/freebsd-386-11_4
2021-08-25T18:34:10-e898025/ead3fe0/freebsd-386-12_2

CC @neild

@bcmills bcmills added OS-FreeBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Sep 22, 2021
@bcmills bcmills added this to the Go1.18 milestone Sep 22, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Sep 22, 2021

(This is a release-blocker via #11811.)

@neild neild self-assigned this Sep 30, 2021
@neild
Copy link
Contributor

neild commented Oct 2, 2021

This was broken by https://golang.org/cl/347010, which updated the vendored x/net.

This pulled in https://golang.org/cl/321869, which reverts a change to routing message alignment on FreeBSD. ("Empirically, freebsd-386 builders are observing 64-bit aligned routing messages.")

It appears that the alignment of routing messages depends on the syscall used to fetch them. The route.RIBTypeInterface constant in x/net is syscall.NET_RT_IFLIST, but the net package tries to call route.FetchRIB with syscall.NET_RT_IFLISTL.

Unfortunately route.FetchRIB(syscall.AF_UNSPEC, NET_RT_IFLISTL) returns bad data rather than an error. This then leads to the test in x/net/ipv6 attempting to listen on "0:fe:8000::%lo0" (note the erroneous leading "0:") and failing.

(Prior to https://golang.org/cl/347010, this test passed because we failed to parse any interfaces correctly, and therefore never even attempted to call net.ListenPacket.)

I think the right fix is probably to change the net package to stop trying to pass NET_RT_IFLISTL to route.ParseRIB, rather than the route.RIBTypeInterface constant.

@gopherbot
Copy link

Change https://golang.org/cl/353611 mentions this issue: net: don't use syscall.NET_RT_IFLISTL on FreeBSD

@rsc rsc unassigned neild Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants