Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile/internal/ssa: TestInlineLines fails on Windows #48550

Closed
bcmills opened this issue Sep 22, 2021 · 3 comments
Closed

cmd/compile/internal/ssa: TestInlineLines fails on Windows #48550

bcmills opened this issue Sep 22, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 22, 2021 •
edited

CL 351529 removes a workaround for #43938 on Windows on the regression test for #47880.

Unfortunately, that workaround seems to have been masking another bug on Windows.
https://storage.googleapis.com/go-build-log/033ed565/windows-amd64-2016_fd7dc5ba.log:

--- FAIL: TestInlineLines (0.07s)
    debug_lines_test.go:173: wanted inlines [[3] [4] [5] [4 10] [4 10] [4 11] [5 10] [5 10] [5 11] [4 10 16] [4 11 16] [5 10 16] [5 11 16]] but got []
FAIL
FAIL	cmd/compile/internal/ssa	5.867s

The failing test was added in CL 348970 (CC @dr2chase, @randall77), so this appears to be a test-regression for Go 1.18. (It is not clear to me whether the test regression also represents a regression in functionality.)
@bcmills bcmills added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Sep 22, 2021
@bcmills bcmills added this to the Go1.18 milestone Sep 22, 2021
@dr2chase
Copy link
Contributor

That's not an inlining bug, that's a bug in the regular expression for a path separator in the test.
We don't need this test to run on all OSes, so I would just leave it disabled on Windows like it originally was.

@gopherbot
Copy link

Change https://golang.org/cl/351529 mentions this issue: cmd/compile/internal/ssa: remove workarounds for #43938

@bcmills
Copy link
Contributor Author

bcmills commented Sep 23, 2021

Oh, that doesn't seem at all difficult to fix! I'll fold it in to CL 351529.

@golang golang locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@dr2chase @bcmills @gopherbot