Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/fuzz: test failures since merging dev.fuzz to master #48504

Closed
jayconrod opened this issue Sep 20, 2021 · 3 comments
Closed

internal/fuzz: test failures since merging dev.fuzz to master #48504

jayconrod opened this issue Sep 20, 2021 · 3 comments
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.18

Comments

@jayconrod
Copy link
Contributor

  • build log: TestScript/test_fuzz_cache and TestScript/test_fuzz_seed_corpus fail on linux-386-longtest.
  • build log: Race tests hit unimplemented path in freebsd-amd64-race.
  • build log: Race benchmark exits unexpectedly in windows-amd64-race.
  • build log: Panic in crypto/tls on aix-ppc64.
@jayconrod jayconrod added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) fuzz Issues related to native fuzzing support labels Sep 20, 2021
@jayconrod jayconrod added this to the Go1.18 milestone Sep 20, 2021
@jayconrod jayconrod self-assigned this Sep 20, 2021
@gopherbot
Copy link

Change https://golang.org/cl/351117 mentions this issue: internal/fuzz: temporarily work around test failures after dev.fuzz merge

gopherbot pushed a commit that referenced this issue Sep 21, 2021
internal/fuzz: temporarily work around test failures after dev.fuzz m…
2f70ce3 
…erge

- Skip test_fuzz_cache and test_fuzz_seed_corpus on 386.
- Skip worker benchmarks when race mode is enabled.
- Stub coverage function on platforms we haven't tested yet. It's
  causing package initialization to panic on aix/ppc64.

For #48504

Change-Id: I79318b52b11a33fca66476b5050445d07422ef36
Reviewed-on: https://go-review.googlesource.com/c/go/+/351117
Trust: Jay Conrod <jayconrod@google.com>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/351314 mentions this issue: internal/fuzz: enable instrumentation for 386, arm and re-enable tests

gopherbot pushed a commit that referenced this issue Sep 24, 2021
cmd/go: adjust comments on why fuzzing instrumentation is disabled
d5d3f80 
For #48504
Related #14565

Change-Id: Ibe43c75224525c4b80dbb66a1b6e0d688e47e2e4
Reviewed-on: https://go-review.googlesource.com/c/go/+/351314
Trust: Jay Conrod <jayconrod@google.com>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
@jayconrod
Copy link
Contributor Author

Closing this now.

@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Go Security
Status: No status
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@jayconrod @gopherbot