Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: page number too large when seeing last page of package list #48481

Closed
successgo opened this issue Sep 20, 2021 · 3 comments
Closed
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite

Comments

@successgo
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/search?page=5&q=http

What is your user agent?

google chrome 93.0 on macOS

Screenshot

image
image

What did you do?

search package "http", and see the page 5.

What did you expect to see?

I expect to see page 5 package list.

What did you see instead?

I see error of "Page number too large".

@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2021
@jamalc jamalc added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/unplanned Sep 20, 2021
@jamalc
Copy link

jamalc commented Sep 20, 2021

This looks like a regression @julieqiu, could you take a look?

@jamalc
Copy link

jamalc commented Sep 20, 2021

I think I found the cause. We should increase maxSearchOffset to 100.

@gopherbot
Copy link

Change https://golang.org/cl/350992 mentions this issue: internal/frontend/search: increase max search offset to 100

@golang golang locked and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Development

No branches or pull requests

3 participants