Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: incorrect arm/arm64 simplification rules [1.16 backport] #48474

Closed
gopherbot opened this issue Sep 19, 2021 · 3 comments
Closed

cmd/compile: incorrect arm/arm64 simplification rules [1.16 backport] #48474

gopherbot opened this issue Sep 19, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.10

Comments

@gopherbot
Copy link

@randall77 requested issue #48473 to be considered for backport to the next 1.16 minor release.

@gopherbot please open backport issues.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 19, 2021
@gopherbot gopherbot mentioned this issue Sep 19, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.9 milestone Sep 19, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/351072 mentions this issue: [release-branch.go1.16] cmd/compile: fix simplification rules on arm/arm64

@randall77
Copy link
Contributor

This issue causes miscompilation. It's hard to trigger, but causes the compiler to generate wrong code if it does.

@heschi heschi added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 6, 2021
@mknyszek mknyszek modified the milestones: Go1.16.9, Go1.16.10 Oct 7, 2021
gopherbot pushed a commit that referenced this issue Oct 27, 2021
@randall77 @dmitshur
[release-branch.go1.16] cmd/compile: fix simplification rules on arm/…
cfe182c 
…arm64

Fixes #48474

Change-Id: Ic1e918f916eae223a3b530a51a58f03031924670
Reviewed-on: https://go-review.googlesource.com/c/go/+/350913
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/351072
Reviewed-by: Austin Clements <austin@google.com>
@dmitshur
Copy link
Contributor

Closed by merging cfe182c to release-branch.go1.16.

@golang golang locked and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.10
Development

No branches or pull requests
5 participants
@mknyszek @dmitshur @randall77 @gopherbot @heschi