Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: R15 gets clobbered in plugin mode [issue:43661 also in 1.17and1.17.1] #48468

Closed
zishen opened this issue Sep 19, 2021 · 1 comment
Closed

cmd/asm: R15 gets clobbered in plugin mode [issue:43661 also in 1.17and1.17.1] #48468

zishen opened this issue Sep 19, 2021 · 1 comment
Labels
FrozenDueToAge

Comments

@zishen
Copy link

zishen commented Sep 19, 2021

What version of Go are you using (go version)?
go version : 1.17 and 1.17.1

Does this issue reproduce with the latest release?
Yes

What operating system and processor architecture are you using (go env)?
OS: linux x86_64

What did you do?
When I was in the compilation of a component named of "volcano.sh/volcano", this situation happened:
截图

I found this problem have been solved here and incorporated into the go 1.17, the issue :43661

so, why?

I also in plugin mode.
@randall77
Copy link
Contributor

When dynamic linking (which includes plugin mode, I think), R15 is reserved for the global offset table. User assembly code is not allowed to overwrite it.

This was fixed in xxhash about a month ago: cespare/xxhash@e7a6b52

yselkowitz added a commit to yselkowitz/cloud-event-proxy that referenced this issue Nov 10, 2021
@yselkowitz
Revendor with go 1.17
8c41c09 
Most importantly, update xxhash for cespare/xxhash#57
to fix a build issue with 1.17: golang/go#48468
@yselkowitz yselkowitz mentioned this issue Nov 10, 2021
Merged
yselkowitz added a commit to yselkowitz/cloud-event-proxy that referenced this issue Nov 10, 2021
@yselkowitz
Revendor with go 1.17
60fe459 
Most importantly, update xxhash for cespare/xxhash#57
to fix a build issue with 1.17: golang/go#48468
nishant-parekh pushed a commit to redhat-cne/cloud-event-proxy that referenced this issue Nov 10, 2021
@yselkowitz
Revendor with go 1.17 (#80)
84ad920 
Most importantly, update xxhash for cespare/xxhash#57
to fix a build issue with 1.17: golang/go#48468
@denyeart denyeart mentioned this issue Dec 13, 2021
Closed
ale-linux added a commit to ale-linux/gnark-crypto that referenced this issue Dec 14, 2021
@ale-linux
Permit code to be compiled as a plugin with Go 1.17.x
f8780e9 
In Go version 1.17.x, `R15` is reserved for the GOT (see
golang/go#48468) when the code is built as a
plugin, and code that uses `R15` will fail to build. This PR changes
the designation of registers to fix the compilation errors.

Signed-off-by: Alessandro Sorniotti <aso@zurich.ibm.com>
@ale-linux ale-linux mentioned this issue Dec 14, 2021
Closed
ale-linux added a commit to ale-linux/gnark-crypto that referenced this issue Dec 14, 2021
@ale-linux
Permit code to be compiled as a plugin with Go 1.17.x
603d9d6 
In Go version 1.17.x, `R15` is reserved for the GOT (see
golang/go#48468) when the code is built as a
plugin, and code that uses `R15` will fail to build. This PR changes
the designation of registers to fix the compilation errors.

Signed-off-by: Alessandro Sorniotti <aso@zurich.ibm.com>
@golang golang locked and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@randall77 @zishen @gopherbot