Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: requested package could not be found #48451

Closed
CAFxX opened this issue Sep 17, 2021 · 5 comments
Closed

x/pkgsite: requested package could not be found #48451

CAFxX opened this issue Sep 17, 2021 · 5 comments
Labels
FrozenDueToAge pkgsite
Milestone
pkgsite/unplanned

Comments

@CAFxX
Copy link
Contributor

CAFxX commented Sep 17, 2021 •
edited

I recently created a new public github repo (https://github.com/CAFxX/decommit) but pkg.go.dev seems to be unable to access/parse it.

If I go to https://pkg.go.dev/github.com/CAFxX/decommit I get

image

Once I click on "request", I get almost immediately, "github.com/CAFxX/decommit" could not be found.:

image

If I use go get it works:

❯ mkdir test

❯ cd test

❯ go mod init test
go: creating new go.mod: module test

❯ go get github.com/CAFxX/decommit
go: downloading github.com/CAFxX/decommit v0.0.0-20210917111054-076de2fd09f9
go get: added github.com/CAFxX/decommit v0.0.0-20210917111054-076de2fd09f9
go get: added golang.org/x/sys v0.0.0-20210910150752-751e447fb3d0

Even after running go get, pkgsite still says the same thing. So it seems that pkgsite is somehow choking on that repo.
@gopherbot gopherbot added this to the Unreleased milestone Sep 17, 2021
@CAFxX CAFxX changed the title x/pkgsite: requested package not found x/pkgsite: requested package could not be found Sep 17, 2021
@jamalc jamalc added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/unplanned Sep 20, 2021
@jamalc
Copy link

jamalc commented Sep 20, 2021

I see a fetch module error in the DB.

extractPackages(ctx, "github.com/CAFxX/decommit", "v0.1.1", r, d): module contains 0 packages: bad module

Is it possible the initial fetch contained no packages and the module got stuck in a bad state @jba @julieqiu?

@jba jba self-assigned this Sep 20, 2021
@jba
Copy link
Contributor

jba commented Sep 20, 2021

Having trouble debugging this because it succeeds when I run the worker locally, but gets a 490 on the deployed one, even though they are the same code.

Inserting more logging.

@gopherbot
Copy link

Change https://golang.org/cl/350993 mentions this issue: internal/fetch: add logging

gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 20, 2021
@jba
internal/fetch: add logging
16efb93 
Add logging to understand why github.com/CAFxX/decommit@v0.1.1
returns BadModule.

For golang/go#48451

Change-Id: Ibd5e1a75f59d1066e98624ddb3db7756d2d488e8
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/350993
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/351270 mentions this issue: internal/fetch: log on bad package

@jba jba removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 21, 2021
@jba
Copy link
Contributor

jba commented Sep 21, 2021

I couldn't reproduce this locally because it depends on the Go version. The module builds in 1.17 but not in 1.16, because of the changes being made to build tags:

> git clone https://github.com/CAFxX/decommit
...
> cd decommit
> docker run -v $PWD:/go golang:1.16.7 env GOPATH= go build
go: downloading golang.org/x/sys v0.0.0-20210910150752-751e447fb3d0
//go:build comment without // +build comment

pkgsite runs on App Engine, which is still on 1.16, so we can't process this module. Just add back the // +build comment.

@jba jba closed this as completed Sep 21, 2021
gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 21, 2021
@jba
internal/fetch: log on bad package
5c86378 
Log a BadPackageError from loadPackage.

If all packages in a module failed to load, the errors were
swallowed. They didn't appear in the logs or the DB.

Also, remove the debugging logs inserted recently to find this
problem.

For golang/go#48451

Change-Id: Ide57f38b4187624aca6c0047d8b29e88e1f55f60
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/351270
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@jba jba mentioned this issue Sep 21, 2021
Closed
@rsc rsc unassigned jba Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
4 participants
@CAFxX @gopherbot @jamalc @jba