Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text/template: should t.init() be executed before t.muTmpl.Lock() in AddParseTree() method? [1.16 backport] #48443

Closed
gopherbot opened this issue Sep 17, 2021 · 3 comments
Closed

text/template: should t.init() be executed before t.muTmpl.Lock() in AddParseTree() method? [1.16 backport] #48443

gopherbot opened this issue Sep 17, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.9

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #48436 to be considered for backport to the next 1.16 minor release.

@gopherbot Please open backports to 1.16 and 1.17

Fix regression in AddParseTree due to earlier fix for #39807.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 17, 2021
@gopherbot gopherbot mentioned this issue Sep 17, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.9 milestone Sep 17, 2021
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/351116 mentions this issue: [release-branch.go1.16] text/template: initialize template before locking it

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Sep 22, 2021
@toothrot
Copy link
Contributor

Approved. This is a serious issue with no workaround (and a regression).

@toothrot toothrot removed the CherryPickCandidate Used during the release process for point releases label Sep 22, 2021
@gopherbot
Copy link
Contributor Author

Closed by merging 7d57324 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Sep 23, 2021
@ianlancetaylor
[release-branch.go1.16] text/template: initialize template before loc…
7d57324 
…king it

For #39807
For #48436
Fixes #48443

Change-Id: I75f82fd8738dd2f11f0c69b1230e1be1abc36024
Reviewed-on: https://go-review.googlesource.com/c/go/+/350730
Trust: Ian Lance Taylor <iant@golang.org>
Trust: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
(cherry picked from commit ba1c52d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/351116
@golang golang locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.9
Development

No branches or pull requests
2 participants
@toothrot @gopherbot