Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/text/language: ExampleMatcher test is broken #48361

Closed
ameowlia opened this issue Sep 13, 2021 · 2 comments
Closed

x/text/language: ExampleMatcher test is broken #48361

ameowlia opened this issue Sep 13, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@ameowlia
Copy link
Contributor

What version of Go are you using (go version)?

go version go1.17 darwin/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/adowns/Library/Caches/go-build"
GOENV="/Users/adowns/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/adowns/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/adowns/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.17"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/adowns/workspace/text/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/4c/1b3s36l94blb6xg1_4p_13800000gn/T/go-build2465748359=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Ran the example for language.Matcher. See website here.

What did you expect to see?

A working example.

What did you see instead?

go: finding module for package golang.org/x/text/language
go: downloading golang.org/x/text v0.3.7
./prog.go:84:1: syntax error: unexpected EOF, expecting }

Also, once I fixed the syntax error, the test was failing.
@gopherbot gopherbot added this to the Unreleased milestone Sep 13, 2021
@gopherbot
Copy link

Change https://golang.org/cl/349552 mentions this issue: language: fix ExampleMatcher test

@ameowlia ameowlia mentioned this issue Sep 13, 2021
Closed
@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 14, 2021
@gopherbot
Copy link

Change https://golang.org/cl/350995 mentions this issue: cmd/compile: fix ExampleInfo output

@golang golang locked and limited conversation to collaborators Sep 24, 2022
xhit pushed a commit to xhit/text that referenced this issue Oct 10, 2022
@ameowlia @xhit
language: fix ExampleMatcher output
c7effe1 
This removes the "TODO" after the output section, which was preventing
this test from running properly and from running in pkg.go.dev. Fixing
this revealed that many of the outputs were out of date and needed to be
updated as well.

Fixes: golang/go#48361

Change-Id: I495e4eb83f071d4d9810bf44bfabe3258a6220c8
Reviewed-on: https://go-review.googlesource.com/c/text/+/349552
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
Trust: Marcel van Lohuizen <mpvl@golang.org>
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
Reviewed-by: Amelia Downs <adowns@vmware.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ALTree @ameowlia @gopherbot