Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/benchmarks: missing function body on riscv64 #48355

Closed
mengzhuo opened this issue Sep 13, 2021 · 3 comments
Closed

x/benchmarks: missing function body on riscv64 #48355

mengzhuo opened this issue Sep 13, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@mengzhuo
Copy link
Contributor

Linux-riscv64-unmatched has enabled benchmarks sub-repo for testing and it found a outdated mod

go: downloading github.com/BurntSushi/toml v0.3.1
# golang.org/x/sys/unix
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20190312061237-fead79001313/unix/syscall_linux_gc.go:10:6: missing function body
....

https://build.golang.org/log/61630e75a5fcca54c565b180a5c5284cf9a8e6db
@gopherbot gopherbot added this to the Unreleased milestone Sep 13, 2021
@mengzhuo
Copy link
Contributor Author

https://go-review.googlesource.com/c/benchmarks/+/349589

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/349589 mentions this issue: misc: update go.mod for riscv64

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 14, 2021
@cagedmantis
Copy link
Contributor

/cc @dr2chase @jeremyfaller

@golang golang locked and limited conversation to collaborators Sep 15, 2022
DarrylWong pushed a commit to DarrylWong/go-benchmarks that referenced this issue Apr 22, 2024
@mengzhuo
go.mod: update go.mod for riscv64
d747fd7 
Fixes golang/go#48355

Change-Id: I04d746dfe00bc4ef3e4281aca35441250dbf36c8
DarrylWong pushed a commit to DarrylWong/go-benchmarks that referenced this issue Apr 22, 2024
@mengzhuo
misc: update go.mod for riscv64
5f2064c 
Fixes golang/go#48355

Change-Id: I04d746dfe00bc4ef3e4281aca35441250dbf36c8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@cagedmantis @mengzhuo @gopherbot