Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: incorrect instructions for local go tour #48347

Closed
chasecaleb opened this issue Sep 12, 2021 · 1 comment
Closed

x/website: incorrect instructions for local go tour #48347

chasecaleb opened this issue Sep 12, 2021 · 1 comment
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@chasecaleb
Copy link

What version of Go are you using (go version)?

> go version
go version go1.17.1 linux/amd64

Does this issue reproduce with the latest release?

This is the latest release

What operating system and processor architecture are you using (go env)?

Linux and x86_64, but that isn't relevant to the issue.

What did you do?

> go get golang.org/x/tour
...
> ls -la ~/go/bin/tour
ls: cannot access 'tour': No such file or directory

What did you expect to see?

The tour binary would be available, as according to https://golang.org/doc/#go_tour:

You can take the tour online or install it locally with:
$ go get golang.org/x/tour
This will place the tour binary in your workspace's bin directory.

What did you see instead?

It wasn't available. After 10 minutes of searching I finally found https://tour.golang.org/welcome/3, which has the correct command to run:

go install golang.org/x/website/tour@latest

Since this is one of the first things that newcomers to Go may attempt to do, fixing the outdated documentation at https://golang.org/doc/#go_tour seems important.

P.S. I'm reporting this issue via this template because the "report a website issue" link at the bottom of https://golang.org/doc/#go_tour took me here.
@gopherbot gopherbot added this to the Unreleased milestone Sep 12, 2021
@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 13, 2021
@ALTree ALTree self-assigned this Sep 13, 2021
@gopherbot
Copy link

Change https://golang.org/cl/349529 mentions this issue: _content/doc: update local tour installation instructions

@rsc rsc unassigned ALTree Jun 23, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
_content/doc: update local tour installation instructions
4f7f647 
We already use go install for the installation instructions in the
tour itself, but the command shown in the root doc document still uses
go get, which by itself won't install any binary in recent Go
versions. Switch to go install there too.

Fixes golang/go#48347

Change-Id: Iad6b22010c92ff0f60df47804fabdd3a3ac2d5c2
Reviewed-on: https://go-review.googlesource.com/c/website/+/349529
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ALTree @chasecaleb @gopherbot