Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: ensure that workspace mode loads same graph regardless of path #48331

Closed
matloob opened this issue Sep 10, 2021 · 2 comments
Closed

cmd/go: ensure that workspace mode loads same graph regardless of path #48331

matloob opened this issue Sep 10, 2021 · 2 comments
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18

Comments

@matloob
Copy link
Contributor

matloob commented Sep 10, 2021

See golang.org/cl/348649 for an example of where this doesn't happen.
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 13, 2021
@cagedmantis cagedmantis added this to the Backlog milestone Sep 13, 2021
@cagedmantis cagedmantis added the GoCommand cmd/go label Sep 13, 2021
@bcmills
Copy link
Contributor

bcmills commented Aug 25, 2022

This was fixed in CL 362754.

@bcmills bcmills closed this as completed Aug 25, 2022
@bcmills bcmills modified the milestones: Backlog, Go1.18.6 Aug 25, 2022
@gopherbot
Copy link

Change https://go.dev/cl/425485 mentions this issue: cmd/go/testdata/script: remove reference to fixed issue

@dmitshur dmitshur modified the milestones: Go1.18.6, Go1.18 Sep 14, 2022
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 14, 2022
gopherbot pushed a commit that referenced this issue Sep 14, 2022
@gopherbot
cmd/go/testdata/script: remove reference to fixed issue
72e07db 
The issue referenced in work_prune.txt was fixed in CL 362754, but we
forgot to update the TODO or mark the issue as fixed in the commit
message.

Updates #48331.

Change-Id: Id2115e496aeaef275dd3c8d32c5c5564e6addb07
Reviewed-on: https://go-review.googlesource.com/c/go/+/425485
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@golang golang locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
5 participants
@cagedmantis @dmitshur @bcmills @gopherbot @matloob