Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: gomote ssh connections immediately close #48329

Closed
toothrot opened this issue Sep 10, 2021 · 2 comments
Closed

x/build/cmd/gomote: gomote ssh connections immediately close #48329

toothrot opened this issue Sep 10, 2021 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

What did you do?

gomote ssh user-rakoczy-linux-arm64-aws-0 # or any buildlet on any platform

What did you expect to see?

# Happy debugging.
$

What did you see instead?

# Happy debugging.
Connection to farmer.golang.org closed.

The coordinator logs attribute this to:

Setctty set but Ctty not valid in child

This is likely from upgrading the coordinator from Go 1.13 to something more recent. See creack/pty#96

We currently depend on github.com/kr/pty, and should be using github.com/creack/pty, which is the maintained replacement.
@toothrot toothrot self-assigned this Sep 10, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 10, 2021
@gopherbot gopherbot added this to the Unreleased milestone Sep 10, 2021
@toothrot toothrot added this to In Progress in Go Release Team Sep 10, 2021
@gopherbot
Copy link

Change https://golang.org/cl/349092 mentions this issue: cmd/coordinator: fix gomote ssh connection closing

@gopherbot
Copy link

Change https://golang.org/cl/349091 mentions this issue: cmd/coordinator: update Dockerfile to Go 1.17

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 10, 2021
gopherbot pushed a commit to golang/build that referenced this issue Sep 10, 2021
@toothrot
cmd/coordinator: update Dockerfile to Go 1.17
62419b0 
This updates the coordinator to the latest supported version of Go. The
current version of Go labeled golang:1.17 is 1.17.1.

Use go mod download instead of manually trying to install dependencies
because it's easier to maintain and fast enough for our current needs.
Also, use the correct label syntax.

For golang/go#48329

Change-Id: I3db030624c1be12008705f374b269bc92e60ab25
Reviewed-on: https://go-review.googlesource.com/c/build/+/349091
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Go Release Team automation moved this from In Progress to Done Sep 10, 2021
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot