Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/parser, go/types: remove support for type list syntax (cleanup) #48261

Closed
findleyr opened this issue Sep 8, 2021 · 6 comments
Closed

go/parser, go/types: remove support for type list syntax (cleanup) #48261

findleyr opened this issue Sep 8, 2021 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18

Comments

@findleyr
Copy link
Contributor

findleyr commented Sep 8, 2021

Reminder issue.

We still have some code to support the type list syntax (interface{ type A, B }) in go/parser and go/types.

Filing this to make sure it is cleaned up.

CC @griesemer
@findleyr findleyr added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 8, 2021
@findleyr findleyr added this to the Go1.18 milestone Sep 8, 2021
@findleyr findleyr self-assigned this Sep 8, 2021
@toothrot
Copy link
Contributor

Checking in on this issue as it's labeled a release blocker for Go 1.18. Is there any update?

@findleyr
Copy link
Contributor Author

No update. This is a lower priority than other issues, so probably won't be done until we're in the freeze.

@griesemer
Copy link
Contributor

griesemer commented Sep 22, 2021 •
edited

This is not a release-blocker. For one, the compiler doesn't actually permit the type list notation anymore (the functionality is disabled) so it's unlikely for go/parser to encounter such code. Secondly, go/types reports an error if it does in fact encounter such code. So no matter how this is sliced and diced, using a type list is invalid code.

@griesemer griesemer changed the title go/parser, go/types: remove support for type list syntax go/parser, go/types: remove support for type list syntax (cleanup) Sep 22, 2021
@ianlancetaylor
Copy link
Contributor

@griesemer @findleyr Is there more to do here for 1.18? Thanks.

@griesemer
Copy link
Contributor

@findleyr If this is only about cleaning up/removing unused code, let's move it to 1.19.

@findleyr
Copy link
Contributor Author

Err, sorry for the lack of response on this issue.

This was done in https://go.dev/cl/359135.

@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
5 participants
@toothrot @ianlancetaylor @griesemer @gopherbot @findleyr