-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev.fuzz] panic when corpus file exists #48228
Comments
@golang/fuzzing |
Bisected this and found e5247f7 to be the first bad commit. |
@kokes Great thanks for bisecting and finding the culprit CL. We'll take a look and plan to fix this soon. |
Change https://golang.org/cl/348381 mentions this issue: |
The coordinator needs to marshal data that was provided via f.Add. However, it was also attempting to marshal data that was in testdata, which was not needed, and was causing a panic. This change fixes this. Fixes #48228 Change-Id: I1256c5a287b5a09d2f8cca59beb0f0fc06cc3554 Reviewed-on: https://go-review.googlesource.com/c/go/+/348381 Trust: Katie Hockman <katie@golang.org> Run-TryBot: Katie Hockman <katie@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
@katiehockman good stuff, can confirm go test -fuzz no longer panics in my use case! (Not closing as not sure if there's any pending work related to this, feel free to do so yourself.) |
Thanks for verifying! I don't actually know why gopherbot didn't close it, but I'll do so now. |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes (release meaning commit in this case)
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
I updated my gotip (dev.fuzz) version and re-ran my fuzzing script (that previously ran for days and created a few testdata files), it crashed immediately. The only way I could make it not crash was to delete all my corpus files. Here's a full reproducer:
What did you expect to see?
I expected fuzzing to start
What did you see instead?
The text was updated successfully, but these errors were encountered: