Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto: crypto/ssh still uses insecure SHA1 by default, OpenSSH ending support soon #48216

Closed
zrait opened this issue Sep 6, 2021 · 1 comment

Comments

@zrait
Copy link

zrait commented Sep 6, 2021

The code in crypto/ssh/keys.go still uses insecure SHA1 signatures for RSA keys by default (unless the SignWithAlgorithm is called, but many codepaths such as SignCert will eventually call Sign which passes "" to SignWithAlgorithm. OpenSSH is going to disable this signature scheme by default in the next release as noted here.

Since OpenSSH 8.2 ssh-rsa signatures have been disabled for certificate signatures and ssh-keygen has used rsa-sha2-512 as the default for signing certificates.

I could submit a PR changing the signature function for RSA keys to be crypto.SHA512.

I also think that it's probably worth updating the verification to disallow use of SHA1 verification by default.

@gopherbot gopherbot added this to the Unreleased milestone Sep 6, 2021
@seankhliao
Copy link
Member

Duplicate of #37278

@seankhliao seankhliao marked this as a duplicate of #37278 Sep 6, 2021
@golang golang locked and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants