Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: when test times out, there are too many goroutines #4821

Closed
rsc opened this issue Feb 15, 2013 · 1 comment
Closed

net/http: when test times out, there are too many goroutines #4821

rsc opened this issue Feb 15, 2013 · 1 comment
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Feb 15, 2013

net/http test timed out in TestTransportPersistConnLeak.
I don't know why and for the purposes of this bug don't care.
But there are 129 goroutines sitting around, which seems like too many.
They come from:

   1 created by net.newPollServer
  24 created by net/http.(*Server).Serve
  70 created by net/http.(*Transport).getConn
   1 created by net/http.(*timeoutHandler).ServeHTTP
   1 created by net/http.fileTransport.RoundTrip
   2 created by net/http/httptest.(*Server).Start
  25 created by net/http_test.TestTransportPersistConnLeak
   1 created by net/http_test.testHandlerPanic
   1 created by testing.RunTests
   1 created by time.goFunc

Why are there 70 created by getConn? That seems like too many. Are they left over from
earlier tests? Are things not being cleaned up correctly?

Full goroutine dump attached.

Attachments:

  1. httpcrash.txt (85003 bytes)
@bradfitz
Copy link
Contributor

Comment 1:

This issue was closed by revision 65fcb39.

Status changed to Fixed.

@rsc rsc added fixed labels Feb 27, 2013
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants