Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: output does not respect comma as millisecond separator [1.17 backport] #48177

Closed
gopherbot opened this issue Sep 3, 2021 · 3 comments
Closed

time: output does not respect comma as millisecond separator [1.17 backport] #48177

gopherbot opened this issue Sep 3, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.2

Comments

@gopherbot
Copy link

@cherrymui requested issue #48037 to be considered for backport to the next 1.17 minor release.

@gopherbot please consider backporting it into 1.17. Thanks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 3, 2021
@gopherbot gopherbot mentioned this issue Sep 3, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.1 milestone Sep 3, 2021
@thanm thanm modified the milestones: Go1.17.1, Go1.17.2 Sep 9, 2021
@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Sep 15, 2021
@cagedmantis
Copy link
Contributor

This issue has been approved as it is a major issue without any viable workarounds.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 15, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/350149 mentions this issue: [release-branch.go1.17] time: propagate "," separator for fractional seconds into Format

@gopherbot
Copy link
Author

Closed by merging e79c297 to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Sep 15, 2021
@korzhao @ianlancetaylor
[release-branch.go1.17] time: propagate "," separator for fractional …
e79c297 
…seconds into Format

In CL 300996 that fixed issue #6189, we made Parse recognize
"," as a separator for fractional seconds.
However, we didn't modify Format to propagate the separator
verbatim from Parse. Without this change, we break prior
functionality that relied on a comma being used in Format.

For #48037
Fixes #48177

Change-Id: I6565a25e8657ca3747a58b25acba58f27cdcddc0
Reviewed-on: https://go-review.googlesource.com/c/go/+/345438
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Cherry Mui <cherryyz@google.com>
(cherry picked from commit e1c3f21)
Reviewed-on: https://go-review.googlesource.com/c/go/+/350149
Trust: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.2
Development

No branches or pull requests
3 participants
@cagedmantis @gopherbot @thanm