-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/x509: invalid RDNSequence: invalid attribute value: unsupported string type: 18 #48171
Comments
Change https://golang.org/cl/347034 mentions this issue: |
golang.org/x/crypto/cryptobyte, golang.org/x/crypto/cryptobyte/asn1 does not support tag 18 type while standard library encoding/asn1 does. |
Same problem here, example: https://play.golang.org/p/-1pDx9dZNpm |
join the question |
@seankhliao @FiloSottile This is a regression from 1.16 that remains broken even in the latest head. Can the linked CL please be merged, and backported to 1.17? |
@gopherbot please open a backport issue for 1.17. This is a regression in the parser rewrite that prevents parsing some certificates. |
Backport issue(s) opened: #51000 (for 1.17). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases. |
Change https://golang.org/cl/382857 mentions this issue: |
…onents Updates #48171 Fixes #51000 Change-Id: Ia2e1920c0938a1f8659935a4f725a7e5090ef2c0 Reviewed-on: https://go-review.googlesource.com/c/go/+/347034 Trust: Roland Shoemaker <roland@golang.org> Run-TryBot: Roland Shoemaker <roland@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org> (cherry picked from commit 896df42) Reviewed-on: https://go-review.googlesource.com/c/go/+/382857 Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes, the latest release has regression
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
https://play.golang.org/p/gVmDQZr638l
What did you expect to see?
nil (no error when parse certificate)
What did you see instead?
x509: invalid RDNSequence: invalid attribute value: unsupported string type: 18
go 1.17 encoding/x509 parser does not know about Numeric String (type 18 asn.1) while previous version of Golang does.
The text was updated successfully, but these errors were encountered: