Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/workflow: TestParallelism is flaky #48158

Closed
dmitshur opened this issue Sep 2, 2021 · 2 comments
Closed

x/build/internal/workflow: TestParallelism is flaky #48158

dmitshur opened this issue Sep 2, 2021 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Sep 2, 2021

This seems to happen occasionally, suggesting the test is flaky:

--- FAIL: TestParallelism (0.15s)
    workflow_test.go:122: task sleep #1  : started
    workflow_test.go:122: task sleep #2  : started
    workflow_test.go:126: task sleep #1  : done: {}
    workflow_test.go:126: task sleep #2  : done: {}
    workflow_test.go:75: too much time elapsed: 152.3438ms
FAIL
FAIL	golang.org/x/build/internal/workflow	0.306s

CC @golang/release.
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 2, 2021
@dmitshur dmitshur added this to the Unreleased milestone Sep 2, 2021
@heschi heschi self-assigned this Sep 2, 2021
@bcmills
Copy link
Contributor

bcmills commented Sep 2, 2021

Indeed:
greplogs --dashboard -md -l -e 'FAIL: TestParallelism'

2021-09-01T14:30:33-3b206e5/36c1717/windows-amd64-2016
2021-09-01T14:30:33-3b206e5/ead3fe0/windows-386-2008
2021-08-31T22:15:11-6d7e13e/ec51703/darwin-amd64-11_0
2021-08-31T22:02:31-55fdac8/0d53084/windows-386-2008
2021-08-31T19:10:05-6e4f69a/891470f/windows-386-2008
2021-08-27T18:46:32-42a539e/bdc1bef/windows-amd64-2016
2021-08-26T15:25:13-3a56891/0d53084/windows-amd64-2016
2021-08-26T15:25:13-3a56891/39eb1cc/windows-386-2008
2021-08-23T17:24:28-f087b01/6cf1d5d/windows-386-2008
2021-08-23T17:24:28-f087b01/c2f96e6/windows-386-2008
2021-08-23T17:24:28-f087b01/e1fcf88/windows-386-2008
2021-08-23T17:24:28-f087b01/e679879/windows-386-2008
2021-08-20T16:41:11-8b42ff7/0d53084/windows-386-2008
2021-08-20T16:41:11-8b42ff7/3034463/windows-amd64-2016
2021-08-20T16:41:11-8b42ff7/457418b/windows-386-2008
2021-08-20T16:41:11-8b42ff7/ab9aaf4/windows-386-2008
2021-08-20T15:22:13-701f717/e9e0d1e/windows-386-2008
2021-08-17T16:28:03-808d0cd/0d53084/windows-386-2008
2021-08-17T16:28:03-808d0cd/ec51703/windows-386-2008
2021-08-16T22:08:05-d2dcbf3/8ff16c1/windows-386-2008
2021-08-16T22:08:05-d2dcbf3/a304273/windows-amd64-longtest
2021-08-16T22:07:56-24f60cc/0d53084/windows-386-2008
2021-08-16T22:07:56-24f60cc/c04a32e/windows-amd64-2016
2021-08-16T20:25:05-6437f7a/ec51703/windows-386-2008

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 2, 2021
@gopherbot
Copy link

Change https://golang.org/cl/347412 mentions this issue: internal/workflow: fix flaky TestParallelism

@rsc rsc unassigned heschi Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @heschi