Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: get panics with "can't find reason for requirement on" [1.17 backport] #48156

Closed
gopherbot opened this issue Sep 2, 2021 · 3 comments
Closed

cmd/go: get panics with "can't find reason for requirement on" [1.17 backport] #48156

gopherbot opened this issue Sep 2, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go release-blocker
Milestone
Go1.17.1

Comments

@gopherbot
Copy link

@bcmills requested issue #47979 to be considered for backport to the next 1.17 minor release.

@gopherbot, please backport to Go 1.17. This is a cmd/go panic due to an internal invariant violation, which may be confusing for end users to diagnose.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 2, 2021
@gopherbot gopherbot mentioned this issue Sep 2, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.1 milestone Sep 2, 2021
@bcmills bcmills added CherryPickApproved Used during the release process for point releases release-blocker labels Sep 2, 2021
@bcmills
Copy link
Contributor

bcmills commented Sep 2, 2021

Marking as release-blocker: I have a fix and expect to merge it soon, so it would be a bit of a shame for this fix to miss the boat.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 2, 2021
@bcmills bcmills self-assigned this Sep 8, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/348411 mentions this issue: [release-branch.go1.17] cmd/go/internal/modload: scan dependencies of root paths when raising version limits in editRequirements

gopherbot pushed a commit that referenced this issue Sep 8, 2021
@toothrot
[release-branch.go1.17] cmd/go/internal/modload: scan dependencies of…
328cf2e 
… root paths when raising version limits in editRequirements

Updates #47979
Fixes #48156

Change-Id: I1d9d854cda1378e20c70e6c6789b77e42e467ca7
Reviewed-on: https://go-review.googlesource.com/c/go/+/347290
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 409434d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/348411
@gopherbot
Copy link
Author

Closed by merging 328cf2e to release-branch.go1.17.

@dmitshur dmitshur added the GoCommand cmd/go label Sep 9, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go release-blocker
Projects
None yet
Milestone
Go1.17.1
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot