Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: allow x/mobile tests run on darwin/arm64 #48142

Open
changkun opened this issue Sep 2, 2021 · 2 comments
Open

x/build: allow x/mobile tests run on darwin/arm64 #48142

changkun opened this issue Sep 2, 2021 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release Team
Milestone
Unreleased

Comments

@changkun
Copy link
Member

changkun commented Sep 2, 2021 •
edited

The x/mobile is an experimental repository that skips many builders. Its current builders include android/386, android/amd64, and ios/arm64.

While working on CL 346150, we found that tests in x/mobile are not tested on a macOS. This may cause issues:

  • cmd/gomobile may be partially broken without any notice (Mac tests had broken for quite a long time until recent fixes), which leads to the runtime support for iOS being unverifiable (not a wanted behavior).
  • it can cause the review process to confuse because a Mac-specific change is also not verifiable through a Trybot run.

Since we already have a darwin/arm64 environment (darwin-arm64-11_0-toothrot), we may use it as a builder for x/mobile.

A further concern is that x/mobile tests may require an Xcode installation with a valid Apple Developer account. However, Xcode is not forward-compatible (earlier Xcode versions may not work with later Xcode-specific changes). If a CL targets a newer Xcode release, it may not be testable until the environment is ready. Consider this reason, a dedicated environment with multiple Xcode installations may be better.

@dmitshur @hyangah @hajimehoshi
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 2, 2021
@gopherbot gopherbot added this to the Unreleased milestone Sep 2, 2021
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 2, 2021
@cherrymui
Copy link
Member

cc @golang/release

@toothrot toothrot added this to Planned in Go Release Team Sep 7, 2021
@ydnar
Copy link

ydnar commented Sep 17, 2021

A further concern is that x/mobile tests may require an Xcode installation with a valid Apple Developer account. However, Xcode is not forward-compatible (earlier Xcode versions may not work with later Xcode-specific changes). If a CL targets a newer Xcode release, it may not be testable until the environment is ready. Consider this reason, a dedicated environment with multiple Xcode installations may be better.

Most of the tests in x/mobile can be run without a valid Apple Developer account.

I’d be happy to submit a CL that skips certain tests if an Apple Developer account can’t be located on the build host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Status: Planned
Go Release Team
Planned
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@ydnar @changkun @gopherbot @cherrymui