Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: cannot highlight AST lines in ssa.html #48133

Closed
Zheng-Xu opened this issue Sep 2, 2021 · 5 comments
Closed

cmd/compile: cannot highlight AST lines in ssa.html #48133

Zheng-Xu opened this issue Sep 2, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@Zheng-Xu
Copy link
Contributor

Zheng-Xu commented Sep 2, 2021

What version of Go are you using (go version)?

$ go version
go version devel go1.18-7622e41c84 Mon Aug 30 22:09:22 2021 +0000 linux/arm64

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

  1. GOSSAFUNC=main.test go build test.go
  2. Open ssa.html in browser.
  3. Click any lines in any sections other than AST section.
  4. Click any lines in AST section.

What did you expect to see?

Corresponding lines in AST section should be highlight from step 3.
Lines in different sections(including AST) should be highlighted from step 4.

What did you see instead?

No line highlight in AST section from step 3.
No line highlight in any sections from step 4.

This issue was introduced by CL 275785
@gopherbot
Copy link

Change https://golang.org/cl/347269 mentions this issue: cmd/compile/internal/ir: better AST line highlight in ssa.html

@cherrymui cherrymui changed the title Cannot highlight AST lines in ssa.html cmd/compile: cannot highlight AST lines in ssa.html Sep 2, 2021
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 2, 2021
@cherrymui cherrymui added this to the Backlog milestone Sep 2, 2021
@cherrymui
Copy link
Member

cc @dr2chase @josharian

@erifan
Copy link

erifan commented Sep 3, 2021

This is a regression since Go1.17, should we backport it to Go1.17 ?

@cherrymui
Copy link
Member

No. We only backport serious issues without workarounds. This is clearly not serious. And ssa.html is mostly for compiler developers, not for general users.

@erifan
Copy link

erifan commented Sep 3, 2021

No. We only backport serious issues without workarounds. This is clearly not serious. And ssa.html is mostly for compiler developers, not for general users.

Ok.

@golang golang locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@Zheng-Xu @gopherbot @cherrymui @erifan