Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: -keepfuzzing needs renaming, does not exist #48127

Open
rsc opened this issue Sep 2, 2021 · 8 comments
Open

cmd/go: -keepfuzzing needs renaming, does not exist #48127

rsc opened this issue Sep 2, 2021 · 8 comments
Labels
fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Sep 2, 2021

Generally, we try to keep the flag names big-endian, so that related flags all have a common prefix, like bench, benchtime, benchmem; memprofile, memprofilerate; even fuzz, fuzzcachedir, fuzzminimizetime, fuzztime, fuzzworker.

The exception in the go help testflag output is keepfuzzing, which doesn't begin with fuzz. It probably should. Maybe fuzzmore?

Also the flag seems not to be implemented.

% gotip test -v -fuzz=Fuzz -keepfuzzing
flag provided but not defined: -keepfuzzing
Usage of /tmp/go-build1779596492/b001/pkg.test:
	...

/cc @jayconrod @katiehockman

@rsc rsc added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Sep 2, 2021
@rsc rsc added this to the Go1.18 milestone Sep 2, 2021
@ameowlia
Copy link
Contributor

ameowlia commented Sep 2, 2021

fuzzforever? fuzzon? fuzznonstop?

@rsc
Copy link
Contributor Author

rsc commented Sep 3, 2021

fuzzcontinue would probably be fine.

@toothrot toothrot added the fuzz Issues related to native fuzzing support label Sep 22, 2021
@katiehockman
Copy link
Contributor

https://go-review.googlesource.com/c/go/+/351113 removed the documentation for -keepfuzzing since it likely won't make it into this release. (And can always be added back if it does for whatever reason)
So I'll remove the release-blocker label.

-fuzzcontinue seems reasonable to me for when we implement it.

@rogpeppe
Copy link
Contributor

rogpeppe commented Oct 5, 2021

FWIW I'd expect this to be the default - if I'm leaving something fuzzing for days or weeks (as I'm doing currently), I don't want it to stop immediately it finds a crash.
I was surprised when I found out that it did.

Possible flag name: -fuzzonce with the opposite sense to -fuzzcontinue? -fuzzstoponfail ?

@cespare
Copy link
Contributor

cespare commented Oct 5, 2021

@rogpeppe or use the existing -failfast flag?

(Though I'm not sure I agree about inverting the default behavior.)

@AlekSi
Copy link
Contributor

AlekSi commented Oct 29, 2021

or use the existing -failfast flag?

See #45690

@katiehockman katiehockman modified the milestones: Go1.18, Go1.19 Nov 10, 2021
@katiehockman
Copy link
Contributor

This won't happen for 1.18, but I'd like to see it in 1.19. Updated the milestone.

@ianlancetaylor
Copy link
Contributor

CC @golang/fuzzing

Do we want this? The milestone is currently 1.19. Should it be 1.20? Backlog? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: No status
Status: No status
Development

No branches or pull requests

10 participants