Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcrypt: key expansion gets skipped if cost has a value of 31 #4803

Closed
gopherbot opened this issue Feb 13, 2013 · 3 comments
Closed

bcrypt: key expansion gets skipped if cost has a value of 31 #4803

gopherbot opened this issue Feb 13, 2013 · 3 comments

Comments

@gopherbot
Copy link
Contributor

by shreds-of-sanity@gmx.net:

Reference:
http://code.google.com/p/go/source/browse/bcrypt/bcrypt.go?spec=svn.crypto.75e869cbf335427fa8d03e0943662b56b1318ee8&;repo=crypto&r=fa541a5bd620ceb0b7c3c237c3a4f4840cc87fda#206

Description:
Calling GenerateFromPassword() with a "cost" of 31 results in an integer
overflow in expensiveBlowfishSetup(): the value of "rounds" becomes negative
(line 223) and the key expansion loop (line 224) won't be entered.
@minux
Copy link
Member

minux commented Feb 14, 2013

Comment 1:

https://golang.org/cl/7329043

Labels changed: added priority-asap, go1.1, removed priority-triage, go1.1maybe.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Feb 14, 2013

Comment 2:

Anything in a subrepo is not a Go1.1 bug.

Labels changed: removed go1.1.

@minux
Copy link
Member

minux commented Feb 19, 2013

Comment 3:

This issue was closed by revision golang/crypto@eccdd12.

Status changed to Fixed.

@mikioh mikioh changed the title go.crypto/bcrypt: key expansion gets skipped if cost has a value of 31 bcrypt: key expansion gets skipped if cost has a value of 31 Jan 8, 2015
cheffo pushed a commit to cheffo/crypto that referenced this issue Mar 4, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
desdeel2d0m added a commit to desdeel2d0m/crypto that referenced this issue Jul 1, 2024
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants