Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Index another branch (stable) instead of default branch (main or master) #47974

Closed
criscola opened this issue Aug 26, 2021 · 5 comments
Closed

x/pkgsite: Index another branch (stable) instead of default branch (main or master) #47974

criscola opened this issue Aug 26, 2021 · 5 comments
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. pkgsite
Milestone
pkgsite/unplanned

Comments

@criscola
Copy link

What did you do?

I'm tagging my versions in a non-default branch i.e.stable instead of main. Is there any way to make pkg.go.dev index this branch instead of main?

What did you expect to see?

I expected this to work:

github.com/myuser/myrepository@v1.0.0

What did you see instead?

Not Found
@gopherbot gopherbot added this to the Unreleased milestone Aug 26, 2021
@jba jba added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Aug 26, 2021
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Aug 26, 2021
@seankhliao
Copy link
Member

afaik for versioned modules pkg.go.dev doesn't look at branches and just looks at what the proxy has (which itself looks directly at tags)

can you provide the actual repo?

@criscola
Copy link
Author

Hi, thank you for your answer, I tried also some combinations of proxy URLs but I could not find the right one if there is any.

Here's the repo: https://github.com/bedag/kubernetes-dbaas
Current godocs: https://pkg.go.dev/github.com/bedag/kubernetes-dbaas

Latest version should be 1.0.0

@seankhliao
Copy link
Member

your version tag needs a v prefix

@criscola
Copy link
Author

I see. In this case I will open a new issue to discuss this and close this one.

@seankhliao
Copy link
Member

Note there are #41312 for default branch and #46914 for any branch

@criscola criscola mentioned this issue Aug 26, 2021
Closed
@golang golang locked and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
4 participants
@criscola @gopherbot @seankhliao @jba