Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types2: add a test case for imported constraint types into a pre-1.18 package #47967

Closed
griesemer opened this issue Aug 25, 2021 · 1 comment
Closed
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@griesemer
Copy link
Contributor

This is a reminder issue to add some test cases of uses of imported constraint types in a pre-1.18 package.
We already have a test file (cmd/compile/internal/types2/testdata/fixedbugs/issue47818.go2) that just needs to be extended.

We should do this once we have a constraints package checked in; then we can just import that package. (Right now the test harness for types2 doesn't easily allow this.)

For instance, once #45458 is implemented, this issued could be addressed trivially.

@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 25, 2021
@griesemer griesemer added this to the Go1.18 milestone Aug 25, 2021
@griesemer griesemer self-assigned this Aug 25, 2021
@gopherbot
Copy link

Change https://golang.org/cl/363834 mentions this issue: cmd/compile/internal/types2: add test for imported constraints pre-1.18

@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants