Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: make >= go1.16 the bootstrap compiler for all builders #47914

Closed
martisch opened this issue Aug 23, 2021 · 1 comment
Closed

x/build: make >= go1.16 the bootstrap compiler for all builders #47914

martisch opened this issue Aug 23, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release Team
Milestone
Go1.18

Comments

@martisch
Copy link
Contributor

In Proposal #44505 it was accepted to make go1.16 the minimally required Go bootstrap version for go 1.18.

If we want to make the Go 1.18 release have cleanups that remove pre Go 1.16 work arounds in bootstrap and libraries we should upgrade the builders such that cleanup changes for Go 1.18 can still land while the tree is open.

I understand this is a large task as there are many builders so it might not work out in the end to have any changes that really need at least Go 1.16 as a bootstrap version in Go 1.18.

I made a cleanup CL for the sort package: https://go-review.googlesource.com/c/go/+/344351
Unfortunately all of the builders except linux-arm-aws (uses go1.15) failed as they seem to use an older (mostly go1.4) boostrap compiler.

/cc @dmitshur @cagedmantis
@martisch martisch added the Builders x/build issues (builders, bots, dashboards) label Aug 23, 2021
@martisch martisch added this to the Go1.18 milestone Aug 23, 2021
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 23, 2021
@toothrot toothrot added this to Planned in Go Release Team Aug 24, 2021
@martisch
Copy link
Contributor Author

martisch commented Oct 21, 2021 •
edited

Closing as it is unlikely go1.16 will be made the bootstrap version for go1.18+.

Context: #44505 (comment)

Go Release Team automation moved this from Planned to Done Oct 21, 2021
@golang golang locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@cagedmantis @martisch @gopherbot